Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display "evaluating" status for nodes #7577

Open
Tracked by #11980
vitvakatu opened this issue Aug 14, 2023 · 5 comments
Open
Tracked by #11980

Display "evaluating" status for nodes #7577

vitvakatu opened this issue Aug 14, 2023 · 5 comments
Labels

Comments

@vitvakatu
Copy link
Contributor

vitvakatu commented Aug 14, 2023

In #7435 we implemented displaying "pending" status for nodes.

We also need some indication for the nodes that a currently evaluated by the engine, as evaluating a single node can take several minutes in some cases.

Can we make the icon of the currently evaluating component into a spinner?

@hubertp hubertp added x-new-feature Type: new feature request -gui labels Aug 14, 2023
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Sep 6, 2023
@farmaazon farmaazon added -gui and removed -gui labels Feb 26, 2024
@hubertp hubertp assigned 4e6 and unassigned hubertp Mar 11, 2024
@AdRiley AdRiley added this to the Beta Release milestone Mar 22, 2024
@AdRiley AdRiley modified the milestones: Beta Release, Future Release Jun 15, 2024
@JaroslavTulach
Copy link
Member

Preferably this should work in orchestration with progress API

@farmaazon
Copy link
Contributor

Preferably this should work in orchestration with progress API

I see progress field in Pending update. We could display node as being evaluated if progress != 0. If you know better API for this, please let me know.

@JaroslavTulach
Copy link
Member

JaroslavTulach commented Jan 7, 2025

Preferably this should work in orchestration with progress API

I see progress field in Pending update. We could display node as being evaluated if progress != 0. If you know better API for this, please let me know.

Yes, that was my idea, when I introduced the progress field. Thus it'd be:

  • if there is no progress field, the node is pending and not yet being evaluated
  • if there is some value in progress field the node is pending and being evaluated

All that's needed is the IDE to use such info and language server to fill it:

@farmaazon
Copy link
Contributor

Thanks!

@farmaazon
Copy link
Contributor

farmaazon commented Jan 15, 2025

Refinement notes:

  • Do not focus on tracking progress, because it's not implemented in the engine anyway. Just check if > 0.
  • May be implemented as spinner in place of node's icon, with cross-fade animation, so there will be no flickering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📤 Backlog
Development

No branches or pull requests

7 participants