Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One source for icons for Project View and Dashboard. #12062

Open
2 tasks
farmaazon opened this issue Jan 16, 2025 · 6 comments · May be fixed by #12091
Open
2 tasks

One source for icons for Project View and Dashboard. #12062

farmaazon opened this issue Jan 16, 2025 · 6 comments · May be fixed by #12091
Assignees

Comments

@farmaazon
Copy link
Contributor

The Project view reads all its icons from one svg file, generated from Figma with custom plugin. It is useful to have one set of named icons, because we allow users to use them in their methods.

The task is to make dashboard use the same icons system:

  • Make sure that all icons it ises are in the figma project and the icons are re-generated to icons.svg
  • Use exported icons; perhaps by making a small react component similar to SvgIcon.vue
@farmaazon farmaazon added this to the 2025-Q1 Release milestone Jan 16, 2025
@AdRiley AdRiley moved this from ❓New to 🔧 Implementation in Issues Board Jan 23, 2025
@MrFlashAccount
Copy link
Contributor

I think this one depends on introducing a 'shared' folder inside gui, doesn't it?

@AdRiley
Copy link
Member

AdRiley commented Jan 23, 2025

I think that's just an implementation choice on how we do this story. But yes makes sense to move the svg file up a level.

@farmaazon
Copy link
Contributor Author

I imagine having icons (and other stuff) in app/gui/src/assets (instead of two separate assets directories)

The other task is about code, not assets, so I think they're independent.

@MrFlashAccount
Copy link
Contributor

I think pulling assets up makes sense as a prerequisite

@MrFlashAccount
Copy link
Contributor

@AdRiley @farmaazon do we have an issue for that?

@farmaazon
Copy link
Contributor Author

@AdRiley @farmaazon do we have an issue for that?

No, I just assumed it may be part of this task. But you may create separately if you want to handle it this way.

@MrFlashAccount MrFlashAccount linked a pull request Jan 29, 2025 that will close this issue
5 tasks
@MrFlashAccount MrFlashAccount moved this from 🔧 Implementation to 👁️ Code review in Issues Board Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👁️ Code review
Development

Successfully merging a pull request may close this issue.

3 participants