Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required Checks are not being respected when cancelling jobs #12028

Open
hubertp opened this issue Jan 9, 2025 · 0 comments
Open

Required Checks are not being respected when cancelling jobs #12028

hubertp opened this issue Jan 9, 2025 · 0 comments
Labels

Comments

@hubertp
Copy link
Collaborator

hubertp commented Jan 9, 2025

We had recently at least 2 instances when not all Required Checks passed but were still merged. With automatic merge on (CI: Ready to merge label) we had:

In those examples some PR checks failed, one manually triggered a re-run because of flakiness. Then one cancelled the run and the label got picked up and PR merged.
PRs should never be allowed to be merged with required checks not being run successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: New
Development

No branches or pull requests

1 participant