Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild the CI pipeline #5711

Open
kflynn opened this issue Jun 28, 2024 · 2 comments
Open

Rebuild the CI pipeline #5711

kflynn opened this issue Jun 28, 2024 · 2 comments
Assignees

Comments

@kflynn
Copy link
Member

kflynn commented Jun 28, 2024

Emissary 4's build system is so very different from Emissary 3's that I think the smart move here is to toss the existing CI pipeline and recreate something simpler. My gut feel (which might well be wrong!) is that the most sane path forward is maybe to start with a pipeline that does something like

  • run lint
  • run the unit tests
  • if that’s OK, do make images so that goreleaser does its thing and builds images
  • something something E2E testing here at some point?
  • if that’s OK and this is a v4* tag, publish packages?

or something like that. The points here:

  1. We can, and should, run static analysis and unit tests before building images at all. (I suppose we could do this in parallel with building images, but let's start with making it a gate?)
  2. We can, and should, build and test images without ever pushing them to GHCR.
  3. We should only publish to GHCR when the repo has an appropriate tag, because goreleaser makes building your own images reliably really easy.
  4. We may well need to completely redo E2E anyway.
@kflynn kflynn moved this to Todo in Emissary 4 Jun 28, 2024
@kflynn
Copy link
Member Author

kflynn commented Jun 28, 2024

@the-wondersmith and @chen-anders, y'all have expressed interest in this, I believe. 🙂

@kflynn kflynn moved this from Todo to In Progress in Emissary 4 Jun 28, 2024
@the-wondersmith
Copy link

@kflynn absolutely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

2 participants