Include robust check for extracting column names for fingerprints #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AVHopp
changed the title
|
Note: I executed the tests while pinning the version of |
Scienfitz
requested changes
Dec 10, 2024
Scienfitz
approved these changes
Dec 10, 2024
AVHopp
force-pushed
the
hotfix/limit_scikit_fingerprints_version
branch
from
7d8223d to
c516971
Compare
AdrianSosic
reviewed
Dec 11, 2024
AdrianSosic
reviewed
Dec 11, 2024
|
@AdrianSosic anything open or can you approve here? Would make sense to have this merged net as e.g. #442 's test currently always fail due to this. |
AdrianSosic
approved these changes
Dec 13, 2024
AVHopp
force-pushed
the
hotfix/limit_scikit_fingerprints_version
branch
from
d632e08 to
f9066f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #446 by introducing a robust check for different potential formats for feature names.