-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct typo in docs on acquisition functions #442
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code has never been turned into an actual meaningful example anyway 😄 but fixing the type is of course still OK 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR :) Just need to fix and rebase the CHANGELOG, other that it's good to go
612753b
to
ae1174c
Compare
fyi I
|
Thank you. I tried to do rebase as it was needed due to changelog, but it seems I messed it up? @AVHopp the failing test is due to scikit fingerprints right? |
@Hrovatin , yes it seems like the tests still fail due to the fingerprints error. We could merge the corresponding PR first, then we should be able t verify this. |
ae1174c
to
91e3e92
Compare
@Hrovatin please analyze what happened with the rebase so it doesnt happen again, seems to me maybe it was maybe rebased onto the wrong branch or so. In any case, be sure to have a backup branch before you do the rebase and let us know if you have any questions / uncertainty around rebasing. |
There was a small typo.