Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WItemImage #30

Open
CalmBit opened this issue Aug 26, 2017 · 8 comments
Open

WItemImage #30

CalmBit opened this issue Aug 26, 2017 · 8 comments

Comments

@CalmBit
Copy link
Contributor

CalmBit commented Aug 26, 2017

Asking if anyone would want something like this in Concrete - essentially, a widget to display an ItemStack, along with a tooltip, almost exactly like how it's displayed within the vanilla Villager trading GUI.

@falkreon
Copy link
Member

We could really use something like this. Implementation-wise, it'd probably wind up needing an ItemSlot peer at Integer.MIN_VALUE coords just like the FluidItemStick we use in fluid tank displays. Drawing the slot at that point is pretty straightforward, but it'd need a little extra babysitting for the tooltip. I'd welcome a PR on that.

@CalmBit
Copy link
Contributor Author

CalmBit commented Aug 26, 2017

I don't think you'd need an ItemSlot peer if you utilized an internal ItemStack, but i'm not sure if you're looking to clutter up the widget that way, or if I'm missing something about the way they're handled.

@CalmBit
Copy link
Contributor Author

CalmBit commented Aug 26, 2017

See this part of Ville for a little bit of context (super, SUPER barebones) as to what I'm talking about.

@unascribed
Copy link
Contributor

You can just place a normal Slot at the correct location, disallow modifying it, and turning off the slot highlight rendering. I believe these are all simple overrides on Slot.

@darkevilmac
Copy link
Member

You can just place a normal Slot at the correct location, disallow modifying it, and turning off the slot highlight rendering. I believe these are all simple overrides on Slot.

Seems a lot easier to just have a widget to draw it for you imo.

@unascribed
Copy link
Contributor

Other than the tooltip and needing to sync the ItemStack...

@darkevilmac
Copy link
Member

Ah, didn't see that a tooltip was needed. Just having a custom slot definitely makes more sense in this case.

@falkreon
Copy link
Member

Partially addressed by 7d7c28f with WItemDisplay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants