-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WItemImage #30
Comments
We could really use something like this. Implementation-wise, it'd probably wind up needing an ItemSlot peer at Integer.MIN_VALUE coords just like the FluidItemStick we use in fluid tank displays. Drawing the slot at that point is pretty straightforward, but it'd need a little extra babysitting for the tooltip. I'd welcome a PR on that. |
I don't think you'd need an ItemSlot peer if you utilized an internal ItemStack, but i'm not sure if you're looking to clutter up the widget that way, or if I'm missing something about the way they're handled. |
See this part of Ville for a little bit of context (super, SUPER barebones) as to what I'm talking about. |
You can just place a normal Slot at the correct location, disallow modifying it, and turning off the slot highlight rendering. I believe these are all simple overrides on Slot. |
Seems a lot easier to just have a widget to draw it for you imo. |
Other than the tooltip and needing to sync the ItemStack... |
Ah, didn't see that a tooltip was needed. Just having a custom slot definitely makes more sense in this case. |
Partially addressed by 7d7c28f with WItemDisplay |
Asking if anyone would want something like this in Concrete - essentially, a widget to display an ItemStack, along with a tooltip, almost exactly like how it's displayed within the vanilla Villager trading GUI.
The text was updated successfully, but these errors were encountered: