PanelWindow: divide dimensions by scale on Wayland #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't fully test opening indicators on X11 because of #564 :( But theoretically this only does things on Wayland so 🤷♀️ |
|
It seems this is only needed when fractional scaling is disabled (since it does logical layout instead of physical). Otherwise it will reintroduce the issue fixed in #559. Maybe we can do it depending on whether it's enabled? |
|
@leolost2605 ah is there a simple way to test for that? |
|
Hmm I dug a bit through gtk api but I only found stuff for GTK4 so I was kinda hoping somebody else knew something. I'll prepare a branch where we ask mutter via dbus :) |
|
Closing since you proposed a better branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #562
Test panel size on: