Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-progress messages do not persist if you view room info or navigate away from composer #2275

Closed
wrjlewis opened this issue Dec 20, 2023 · 10 comments · Fixed by #2323
Closed
Assignees
Labels
A-Composer A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@wrjlewis
Copy link

Steps to reproduce

  1. Where are you starting? What can you see?
    Any room, type something in the composer but don't send it.
  2. What do you click?
    The room icon to view details about the room (eg to get to the people list)
  3. More steps…
    Return to the main chat pane and your half-written message is gone

Outcome

What did you expect?

For the message to persist when clicking room info, or even visiting a different room in the meantime.

What happened instead?

The message disappeared.

RPReplay_Final1703075030.MP4

Your phone model

iPhone 12 Pro

Operating system version

iOS 17.1.2

Application version

1.4.3

Homeserver

Synapse 1.98 @ wi11.co.uk

Will you send logs?

No

@stonerl
Copy link

stonerl commented Jan 2, 2024

This also happens when leaving the app. E.g. switching between Element X and Safari.

@stefanceriu
Copy link
Member

This also happens when leaving the app

While the original report is a known unimplemented feature I can't reproduce yours. Do you do anything else apart from just switching apps? 🤔

@stonerl
Copy link

stonerl commented Jan 3, 2024

@stefanceriu It occurs on an iPad. Here is a GIF, that illustrates it:

RPReplay_Final1704288197

@stefanceriu
Copy link
Member

stefanceriu commented Jan 4, 2024

Tracked it down to here and here but I don't understand why that's necessary. Do you happen to know @Velin92?

(I believe the reason it only happens on an ipad is because we rebuild part of the hierarchy to fix a bug with missing toolbar icons)

@wrjlewis
Copy link
Author

@Velin92 The original report here was not the iPad issue (albeit thankful for fixing that 🙌), should we keep this issue open to cover what was originally raised? Or is that covered elsewhere

@stefanceriu
Copy link
Member

is that covered elsewhere

No no, let's keep this one open, I'll convert it to a feature

@stefanceriu stefanceriu reopened this Jan 12, 2024
@stefanceriu stefanceriu added A-Timeline A-Composer T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience and removed T-Defect labels Jan 12, 2024
@Velin92
Copy link
Member

Velin92 commented Jan 12, 2024

We also fixed the issue of the composer keeping its content when navigating within the room details, which should be the intended behaviour

Simulator.Screen.Recording.-.iPhone.15.-.2024-01-12.at.11.06.23.mp4

Keeping the content while navigating to other rooms, or after the room is dismissed instead is feature we have not developed yet

@wrjlewis
Copy link
Author

Thats awesome! Thanks

Just to be pedantic, the issue also mentioned keeping content when navigating to different rooms, has that also been added?

@stefanceriu
Copy link
Member

Okay, we're just going to open a different ticket for the feature and keep this one just for the bugs

@stefanceriu stefanceriu added T-Defect and removed T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels Jan 12, 2024
@stefanceriu
Copy link
Member

Found one on element-meta element-hq/element-meta#1776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
4 participants