Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to unpin a deleted message #28108

Closed
Glandos opened this issue Sep 27, 2024 · 1 comment · Fixed by element-hq/matrix-react-sdk#98
Closed

Unable to unpin a deleted message #28108

Glandos opened this issue Sep 27, 2024 · 1 comment · Fixed by element-hq/matrix-react-sdk#98
Assignees
@florianduros
Labels
A-Message-Pinning O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression Z-Labs

Comments

@Glandos
Copy link
Contributor

Glandos commented Sep 27, 2024

Steps to reproduce

  1. Pin a message
  2. Go to to pinned message in the right panel
  3. Click on the 3-dots button, and then "Delete"

Outcome

What did you expect?

After deletion, it should be possible to unpin the "Deleted message" message.

What happened instead?

The "Unpin" option is not there anymore, message is pinned forever.

Operating system

Debian

Browser information

Firefox 130

URL for webapp

app.element.io

Application version

Version de Element : 1.11.78 Version crypto : Rust SDK 0.7.2 (7a21514), Vodozemac 0.7.0

Homeserver

matrix.org

Will you send logs?

No
@Glandos
Copy link
Contributor Author

Glandos commented Sep 27, 2024

It's maybe caused by a confusing UI in this panel, though, between "Unpin" and "Delete", since "Delete" in the context of "Pinned messages" can mean "Delete the pin"

@dosubot dosubot bot added A-Message-Pinning O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Sep 27, 2024
@MidhunSureshR MidhunSureshR added S-Major Severely degrades major functionality or product features, with no satisfactory workaround and removed S-Minor Impairs non-critical functionality or suitable workarounds exist labels Sep 30, 2024
@florianduros florianduros self-assigned this Sep 30, 2024
@florianduros florianduros mentioned this issue Sep 30, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@florianduros florianduros

Labels
A-Message-Pinning O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression Z-Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow to unpin redacted event element-hq/matrix-react-sdk
3 participants
@Glandos @florianduros @MidhunSureshR