Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlight text is not accessible on dark theme #27865

Open
kongo09 opened this issue Jul 27, 2024 · 7 comments
Open

highlight text is not accessible on dark theme #27865

kongo09 opened this issue Jul 27, 2024 · 7 comments
Labels
A-Timeline S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@kongo09
Copy link

kongo09 commented Jul 27, 2024

Steps to reproduce

  1. Visit the timeline
  2. Observe a message that is a reply

Outcome

What did you expect?

Text with accessible contrast.

What happened instead?

Text has low contrast that is hard to read and fails accessibility test.

Evidence: https://webaim.org/resources/contrastchecker/?fcolor=F34441&bcolor=1D1F24

image

Operating system

Windows 11

Application version

Element version: 1.11.71 Crypto version: Rust SDK 0.7.1 (80a151e), Vodozemac 0.6.0

How did you install the app?

element.io

Homeserver

element.io

Will you send logs?

No

@dosubot dosubot bot added A-Timeline S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jul 27, 2024
@t3chguy
Copy link
Member

t3chguy commented Jul 29, 2024

Can you share a screenshot of the fault itself? Are you using the high contrast theme?

@t3chguy t3chguy added the X-Needs-Info This issue is blocked awaiting information from the reporter label Jul 29, 2024
@kongo09
Copy link
Author

kongo09 commented Jul 29, 2024

image

@t3chguy
Copy link
Member

t3chguy commented Jul 29, 2024

Are you using the high contrast theme?

@t3chguy
Copy link
Member

t3chguy commented Jul 29, 2024

Looks fine in High Contrast mode

image
image

Looks fine in Light theme

image

Also cannot reproduce in dark mode

image

These colours come from Compound which has contrast testing designed into it

@kongo09
Copy link
Author

kongo09 commented Jul 29, 2024

In High Contrast theme, other items are not accessible, e.g.

image

https://webaim.org/resources/contrastchecker/?fcolor=FFFFFF&bcolor=D7DCE2

But in any case, the red color of the dark theme feels completely unnecessary and not even visually connected to a dark theme. Not sure why you cannot reproduce this?

@t3chguy
Copy link
Member

t3chguy commented Jul 29, 2024

Right so you meant ping colour not reply colour

@t3chguy t3chguy removed X-Needs-Info This issue is blocked awaiting information from the reporter X-Cannot-Reproduce labels Jul 29, 2024
@kongo09
Copy link
Author

kongo09 commented Jul 29, 2024

Hm, not sure what a "ping" colour is, but I'm talking about the red.

@t3chguy t3chguy changed the title Reply text is not accessible highlight text is not accessible on dark theme Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Timeline S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

2 participants