Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element asks to verify its session while it is already verified #27710

Closed
janvlug opened this issue Jul 11, 2024 · 10 comments
Closed

Element asks to verify its session while it is already verified #27710

janvlug opened this issue Jul 11, 2024 · 10 comments
Labels
A-E2EE-SAS-Verification A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@janvlug
Copy link

janvlug commented Jul 11, 2024

Steps to reproduce

  1. Open Element Desktop (but I think I've seen this in the browser as well).

Outcome

What did you expect?

A verified session

What happened instead?

I get a "popup window" with the text: Verify this session. Other users may not trust it.
Screenshot:
image

When I do the whole verify procedure. This "popup window" does not disappear. Regardless of how often I do the Verify procedure. The "popup window" stays. The only way to get rid of it is clicking the Later button.

Maybe this is the reason that this "popup window" appears again later (usually after a day or so, or maybe after starting Element again).

I see this in the browser console, maybe it is related:

WARN matrix_sdk_crypto::store: The user has a pending `/key/query` request which did not finish yet, some devices might be missing.
    user_id="@strypey:feneas.org"
    at /home/runner/.cargo/git/checkouts/matrix-rust-sdk-1f4927f82a3d27bb/a2235d5/crates/matrix-sdk-crypto/src/store/mod.rs:218
    in matrix_sdk_crypto::machine::get_identity with user_id="@strypey:feneas.org" timeout=Some(1s)

Note: exactly the same happens on Element Desktop.

Operating system

Linux Fedora Wayland

Browser information

Firefox 128

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

Yes

@dosubot dosubot bot added A-E2EE-SAS-Verification S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jul 11, 2024
@florianduros florianduros added the X-Needs-Info This issue is blocked awaiting information from the reporter label Jul 12, 2024
@florianduros
Copy link
Member

Hello ! Thanks for raising this issue.

Can you share logs too to help us to debug it ? (Settings > Help & About > Submit logs)

@janvlug
Copy link
Author

janvlug commented Jul 12, 2024

Debug logs should have been submitted. Should I see them here in this issue?

@t3chguy
Copy link
Member

t3chguy commented Jul 12, 2024

No as they are submitted to a private repo

image

@florianduros florianduros added O-Uncommon Most users are unlikely to come across this or unexpected workflow A-Element-R Issues affecting the port of Element's crypto layer to Rust and removed X-Needs-Info This issue is blocked awaiting information from the reporter labels Jul 12, 2024
@janvlug
Copy link
Author

janvlug commented Jul 19, 2024

I have the impression that there is some issue with my account recovery or account backup.
I tried to recover in Fractal, and I got this message, maybe it gives some hints on what is wrong:
image

@janvlug
Copy link
Author

janvlug commented Jul 20, 2024

I tried to dive a bit further into the issue that I have with Element web and Element desktop.
On element desktop, I went into Settings:
image
When I click here on "Connect this session to Key Backup" I get a message:
Keys restored
Successfully restored 1592 keys
Next I click "OK"
The Settings windows disappears after clicking "OK". This already seems weird to me, I would expect to go back to the Settings window.
If I open the Settings window again, and go to Encryption | Secure Backup I still get exactly the same as in the screenshot above. Still stating:
not backing up your keys
Secret storage: not ready
Active backup version: None
This backup can be restored on this session

@andybalaam andybalaam changed the title Element ask to verify its session while it is already verified Element asks to verify its session while it is already verified Jul 22, 2024
@andybalaam
Copy link
Contributor

We suspect this is a duplicate of the broken 4S issue. @richvdh will folllow up, not necessarily to fix but to identify the problem.

@janvlug
Copy link
Author

janvlug commented Jul 22, 2024

I will probably not be able to reproduce this any more, because I reset Secure Backup and Cross-signing. Both have a ✅ now in settings. Having unverified sessions all the time was getting too annoying for me. I did make some notes about what I roughly did.

@richvdh
Copy link
Member

richvdh commented Jul 23, 2024

Sorry for the delay on getting back to you on this - there have been some vacations in the team in the last couple of weeks :(.

I've investigated what happened here, and it looks like your device had gotten itself into a bit of a mess. I've opened #27805 to track the problem.

Thanks for the report!

@richvdh richvdh closed this as completed Jul 23, 2024
@janvlug
Copy link
Author

janvlug commented Jul 23, 2024

Thanks, no problem. I'm glad that you managed to make a new issue out of it which is way clearer than my report here.

@barathrm
Copy link

I have the same issue, and I'm wondering whether it's the same potential cause (#27805).

Under Security/Cross-signing, it says Cross-signing is not set up., even though I have cross-verified the device from another device. The button under "cross-signing" says set up secure backup, but I don't want the secure backup, I've historically just used key sharing across verified devices...

Am I missing something? I've uploaded logs from an element login where I've cross-verified it and then manually imported e2e room keys from another device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE-SAS-Verification A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

6 participants