-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When Security Key is changed on another client during web login, web ignores the new key and blocks #27155
Comments
edits : fixed a screenshot, and unmixed some steps. |
I am working on understanding the code around this. There's a lot of stuff :) |
Le même problème chez Element : #27155 ? |
@NicolasBuquet you linked to this same issue? |
@t3chguy |
Excellent bug report - thank you! |
Steps to reproduce
Outcome
What did you expect?
Security key is right, I can continue to login
What happened instead?
Web client says security key is wrong, I cannot continue.
Workaround and additional info
If instead I do these same steps in a different order, I can continue :
6. android : recreate the security key.
5. web : Click Verify with Security Key. You are now in AccessSecretStorageDialog
7. web : input the new security key
Or if I do the buggy flow, but then add steps :
8. Click Go back
9. Click Verify with Security Key. You are now in AccessSecretStorageDialog
10 : input the new security key : it works
Conclusion : opening the AccessSecretStorageDialog seems to initialise something, that is then not refreshed to take into account the change that is made to secret storage.
How this happened in real life
This bug has really been encountered by a user who was blocked.
She found herself logged out on web client (maybe her browser storage had been erased because of lack of space on disk?)
She logged in again and could not find her security key.
Since she had a session on android, she regenerated the security key on android.
She input it in web and was blocked.
Operating system
macos or windows
Browser information
No response
URL for webapp
app.element.io
Application version
Element version: 1.11.59 Crypto version: Rust SDK 0.7.0 (fac36bc), Vodozemac 0.5.1
Homeserver
matrix.org
Will you send logs?
No
The text was updated successfully, but these errors were encountered: