Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room knocking via spaces doesn't work #27025

Closed
Tracked by #18655
sdrgeek opened this issue Feb 17, 2024 · 2 comments · Fixed by matrix-org/matrix-react-sdk#12404
Closed
Tracked by #18655

Room knocking via spaces doesn't work #27025

sdrgeek opened this issue Feb 17, 2024 · 2 comments · Fixed by matrix-org/matrix-react-sdk#12404
Assignees
@t3chguy
Labels
A-Knocking A-Spaces Spaces, groups, communities O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Labs

Comments

@sdrgeek
Copy link

sdrgeek commented Feb 17, 2024 •
edited
Loading

Steps to reproduce

  1. View Rooms via Space.

  2. Press join button on knocking enabled Room.
    image

  3. Get this error message:
    image

Outcome

What did you expect?

starting a join request

What happened instead?

HTTP 403

Operating system

No response

Browser information

Firefox 115.6.0esr (64-bit)

URL for webapp

No response

Application version

element-web 1.11.58

Homeserver

No response

Will you send logs?

Yes
@sdrgeek
Copy link
Author

sdrgeek commented Feb 17, 2024

correlates to #18655

@sdrgeek sdrgeek changed the title Room knocking via SPaces doesn't work Room knocking via spaces doesn't work Feb 17, 2024
@t3chguy t3chguy mentioned this issue Feb 19, 2024
Open
@florianduros florianduros added S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Spaces Spaces, groups, communities O-Uncommon Most users are unlikely to come across this or unexpected workflow A-Knocking labels Feb 19, 2024
@0x5ECF4ULT
Copy link

0x5ECF4ULT commented Apr 6, 2024 •
edited
Loading

I, too, want to express the importance of this feature. I'm a co-admin for a organizational server. We're joining new users on our HS automatically into a space, but members already having an account on another HS should be able to participate in certain rooms in this space as well. So we just tell them to join the space. We don't want to open this room to the public since the room is, well, members only.
Enabling knocking via rooms would enable said use-case. I would argue that this is a not so uncommon one.

@t3chguy t3chguy added the Z-Labs label Apr 8, 2024
@t3chguy t3chguy self-assigned this Apr 8, 2024
@t3chguy t3chguy mentioned this issue Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Knocking A-Spaces Spaces, groups, communities O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix inability to join a knock room via space hierarchy view matrix-org/matrix-react-sdk
4 participants
@t3chguy @florianduros @0x5ECF4ULT @sdrgeek