Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element-R: Fix up message shields #25321

Closed
4 tasks done
richvdh opened this issue May 9, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#11589
Closed
4 tasks done

Element-R: Fix up message shields #25321

richvdh opened this issue May 9, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#11589
Assignees
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust T-Task Tasks for the team like planning

Comments

@richvdh
Copy link
Member

richvdh commented May 9, 2023

The current way of doing this in the rust sdk is that VerificationState.to_shield_state_* returns a ShieldState, which includes a colour (red/grey/none) and a freeform text field. The latter isn’t great for EW, because we need to maintain a list of translations. It would be preferable to return an enum of some kind. Maybe we can just use the VerificationState and cargo-cult the logic into the js-sdk.

Total estimate: 3.5d, plus updates for existing events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants