Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Element X: Hide the "Join" button after the call has started (Android only) #2608

Closed
fkwp opened this issue Nov 1, 2024 · 2 comments · Fixed by element-hq/element-x-android#3815

Comments

@fkwp
Copy link

fkwp commented Nov 1, 2024

Description

Currently the Call Symbol on the top right of a room will start a new call or becomes a green "Join button" if a call is currently present. In both cases pressing the button starts the Element Call widget.

Now with the Picture-in-Picture feature you can still see the green "Join button" while participating that call which is misleading. This is the case only for Android version, iOS is already hiding the "Join button". It is desired to make Android consistent with it.

Note that this is room specific, meaning that the Join button would be hidden only in the room where the user has joined. Other rooms that have ongoing calls (that the user has not joined) are still showing the Join button.

Acceptance criteria

  • TBD

Size estimate

None

Dependencies

  • None

Out of scope

  • Nothing

Open questions

Questions

No tasks being tracked yet.

Subtasks

Android

No tasks being tracked yet.

iOS

No tasks being tracked yet.

Rust

No tasks being tracked yet.

Other

No tasks being tracked yet.
@mxandreas
Copy link

@fkwp Actually, in iOS we're already hiding the Join button. Therefore we would do the same on Android. As it is not critical to have the hang up button there, I would keep it simple. Do you agree?

@mxandreas mxandreas changed the title [Story] Element X: After a call has started switch "Join" Button at the top right of the room into a "Hangup" button [Story] Element X: Hide the "Join" button after the call has started (Android only) Nov 5, 2024
@fkwp
Copy link
Author

fkwp commented Nov 5, 2024

@fkwp Actually, in iOS we're already hiding the Join button. Therefore we would do the same on Android. As it is not critical to have the hang up button there, I would keep it simple. Do you agree?

The thing I like about the hangup button is that you can also notice in the timeline view of that room that a call is in progress. @amshakal wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants