Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support s tags for strikethrough #2368

Open
Erquint opened this issue Mar 21, 2024 · 1 comment
Open

Support s tags for strikethrough #2368

Erquint opened this issue Mar 21, 2024 · 1 comment
Labels
good first issue Good for newcomers O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement

Comments

@Erquint
Copy link

Erquint commented Mar 21, 2024

Opening this issue as a reminder that the <s> tag shouldn't be escaped anymore.

I've been informed that, starting from tomorrow, Matrix protocol specification strongly suggests clients to permit a set of HTML tags, now again including s, as detailed here.

This is changing tomorrow with the Matrix 1.10 spec release. s is preferred over strike, and del is maintained: https://spec.matrix.org/unstable/client-server-api/#mroommessage-msgtypes

@travis:t2l.io

Clients should limit the HTML they render to avoid Cross-Site Scripting, HTML injection, and similar attacks. The strongly suggested set of HTML tags to permit, denying the use and rendering of anything else, is: del, h1, h2, h3, h4, h5, h6, blockquote, p, a, ul, ol, sup, sub, li, b, i, u, strong, em, s, code, hr, br, div, table, thead, tbody, tr, th, td, caption, pre, span, img, details, summary.

Client-Server API | Matrix Specification

Outcome

Currently, sending <s>Strikethrough</s> results in posting \<s>Strikethrough\</s>.

Operating system

Windows/Web

Application version

Future

@t3chguy t3chguy transferred this issue from element-hq/element-web Mar 21, 2024
@dbkr dbkr changed the title Strikethrough tag s strongly suggested to be permitted by clients again. Support s tags for strikethrough Mar 22, 2024
@dbkr dbkr added T-Enhancement O-Occasional Affects or can be seen by some users regularly or most users rarely and removed T-Defect labels Mar 22, 2024
@dbkr
Copy link
Member

dbkr commented Mar 22, 2024

I think this should be a question of just adding the tag to the allowed list, so a bite-sized thing for a maintainer or even a first-time contributor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants