[Story] Show blocked users

[VolkerJunginger]

Description

As a user that has blocked other users I want to have a place where I can access these user so that I can unblock them.

Acceptance criteria

• No feature flag is required for this feature
• We will introduce a new Blocked users section in the account settings screen
• Tapping on that entry should take the user to the Blocked users screen
• The Blocked users screen will be a list of blocked user matrix identifiers. We are intentionally hiding display names and avatars to avoid offensive content
• Tapping on any of the users should bring up a confirmation alert with options to unblock that particular user or cancel the action
• Loading the list and unblocking users should display platform specific waiting indicators
• Ideally the list should listen to global account blocked user changes and update accordingly.
• Only show the menu item when a user has blocked users.

Leads

• Tech: @stefanceriu
• Design: @amshakal

Designs

Designs for iOS

Designs for Android

Size estimate

S

Dependencies

• None

Out of scope

• Nothing

Open questions

Questions

Beta Give feedback

No tasks being tracked yet.

Subtasks

Android

Beta Give feedback

1. [Task] Show blocked users element-x-android#2418
   T-Task +1
   
2. Hide "Blocked users" menue item if the user has no blocked user element-x-android#2469
   T-Enhancement T-Task +2
   
3. https://github.com/element-hq/element-x-android-rageshakes/issues/1656

iOS

Beta Give feedback

1. [Task] Show blocked users element-x-ios#2486
   T-Task +1
2. Hide "Blocked users" menue item if the user has no blocked user element-x-ios#2516
   T-Enhancement +1

Rust

Beta Give feedback

1. [Task] Expose blocked/ignored users in FFI matrix-org/matrix-rust-sdk#3141
   +0

Other

Beta Give feedback

No tasks being tracked yet.

Sign-off

Android

• Design sign-off on completion
• QA sign-off on completion
• Product sign-off on completion

iOS

• Design sign-off on completion
• QA sign-off on completion
• Product sign-off on completion

[jmartinesp]

Ruma has an API for ignored (blocked) user list: https://docs.rs/ruma-events/latest/ruma_events/ignored_user_list/index.html

AccountData.global contains a list of global account data events that should contain this info, although the only info available at the moment would be a list of ignored user ids, with no actual user info, so we'd have to find a way to fetch that user data.

[daniellekirkwood]

Just a note... On Web you see this by: Settings > Security & Privacy > Advanced > Ignored Users

[jmartinesp]

After taking another look, it seems like most of the data we need is already there: we have the blocked user ids and we can call /_matrix/client/v3/profile/{userId} to get the name and avatar of each ignored user. Since this should be done every time we want to retrieve the list of ignored users, we should probably create a cache, but doing so seems quite trivial as long as we don't expect it to survive app restarts.

With a very naive implementation I got:

// The names and ids here are fine, they were users who were spamming some public rooms:
Ignored users: [
	IgnoredUser(
		id=@eogziyjjfwvqogtunxwqttypsixqowtpkjxafcrundbqvdmsggobqoafzkgqqsejqipmmftibnafourxmkzodhbiihbronbiruxfnxqucbfmczduipnkmwczepvzhikw:matrix.org, 
		avatarUrl=mxc://matrix.org/uXpgyUWGlOofhoXiOfKOgrGA, 
		displayname=eogziyjjfwvqogtunxwqttypsixqowtpkjxafcrundbqvdmsggobqoafzkgqqsejqipmmftibnafourxmkzodhbiihbronbiruxfnxqucbfmczduipnkmwczepvzhikw, 
		blurhash=null
	), 
	IgnoredUser(
		id=@qdpkfmxruncufovojpuectwshoxcuoomjinoscnhqfywxdyauodwqfosjvazrxqanftwvrjupxfhyifrxphksgeogevijqvbgxrraoiuimfbibvhodmekgjtpxnctmvd:matrix.org, 
		avatarUrl=mxc://matrix.org/nJwXVCUphecoPpGHLEfPhyAb, 
		displayname=qdpkfmxruncufovojpuectwshoxcuoomjinoscnhqfywxdyauodwqfosjvazrxqanftwvrjupxfhyifrxphksgeogevijqvbgxrraoiuimfbibvhodmekgjtpxnctmvd,
		blurhash=null
	)
]

[amshakal]

Designs for iOS

Designs for Android

[VolkerJunginger]

@bmarty Is the Android Design for the prompt when unblocking right? The buttons are right-aligned?

[jmartinesp]

@bmarty Is the Android Design for the prompt when unblocking right? The buttons are right-aligned?

Do you mean in the actual implementation? Android dialog buttons are always right-aligned.

[VolkerJunginger]

Ah - ok. Looks weird but ok.

[VolkerJunginger]

On Android unblocking is stuck in a Spinner. The person is already unblocked. Rageshake send

[jmartinesp]

On Android unblocking is stuck in a Spinner. The person is already unblocked. Rageshake send

It should be fixed by element-hq/element-x-android#2554

[VolkerJunginger]

Feature has been handed over to the customer.

[VolkerJunginger]

Customer gives a go for the feature.