Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Change user avatar within EX #2039

Closed
4 tasks done
manuroe opened this issue Sep 6, 2023 · 6 comments
Closed
4 tasks done

[Story] Change user avatar within EX #2039

manuroe opened this issue Sep 6, 2023 · 6 comments

Comments

@manuroe
Copy link
Member

manuroe commented Sep 6, 2023

Description

  • As a user
  • I want to change my avar within the app

Figma link: TBD

Acceptance criteria

  • The user can change their avatar in the app
  • The avatar change is reflected everywhere in the app

Size estimate

S

Dependencies

None

Preconditions

None

Out of scope

?

Open questions

?

Subtasks

Android

  1. T-Task
    jmartinesp

iOS

  1. stefanceriu

Rust

@jmartinesp
Copy link
Member

Should we also allow removing the current avatar?

@manuroe
Copy link
Member Author

manuroe commented Sep 13, 2023

This is a a good idea. I would say if we do it for this screen, we should do it for the room avatar as well.

@VolkerJunginger what do you think? Should we offer the user the option to remove their avatar now?

@VolkerJunginger
Copy link
Contributor

Is this two things? My avatar and the avatar in a room?

@jmartinesp
Copy link
Member

jmartinesp commented Sep 13, 2023

we should do it for the room avatar as well.

That's already the case on Android, that's why I asked since we're more or less copying the code for the UI and event logic and adapting it to different Rust calls 🤔 .

@jmartinesp
Copy link
Member

Is this two things? My avatar and the avatar in a room?

@VolkerJunginger I think he meant for removing the avatar of a room in its settings?

FWIW I uploaded a quick PR in the Rust SDK to allow removing the avatar, in case we want to do it en EX.

@jmartinesp jmartinesp assigned jmartinesp and unassigned ganfra Sep 14, 2023
@VolkerJunginger
Copy link
Contributor

If this is the same thing effort-wise. Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants