Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Threaded message decorator in EX #2037

Closed
5 tasks done
manuroe opened this issue Sep 6, 2023 · 4 comments
Closed
5 tasks done

[Story] Threaded message decorator in EX #2037

manuroe opened this issue Sep 6, 2023 · 4 comments
Labels
App: ElementX Android App: ElementX iOS T-User Story Team: Element X Platform X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA

Comments

@manuroe
Copy link
Member

manuroe commented Sep 6, 2023

Description

  • As a user
  • I want to know when a message is coming from a thread
  • So that I can use the reply action to make my answer goes to a thread. It will not break the UX of other users with matrix clients supported threads

This is a cheap workaround before we implement threads in EX. We are aware that only matrix power users will understand that using the reply button will not break UX on thread-capable apps.

Acceptance criteria

  • Visual indicator like 🧵 on threaded messages in the timeline
  • The action menu must display "Reply in Thread"
  • The composer should have the hint "Reply in Thread"
  • Reply to such a message will appear in the thread on matrix apps that support threads (Element Web and legacy mobile apps). There is nothing to implement here. It is already working

Size estimate

S

Dependencies

  • None

Preconditions

  • None

Out of scope

  • No change in the room list
  • No change in push notifications
  • Polls and Stickers decorations

Open questions

  • None

Subtasks

Android

  1. A-Threads A-Timeline T-Enhancement Z-Schedule
    ganfra
  2. A-Threads A-Timeline O-Frequent S-Minor T-Defect Z-Schedule
    ganfra
  3. A-Threads T-Defect Z-Schedule

iOS

  1. A-Threads A-Timeline T-Enhancement Z-Schedule
    pixlwave

Rust

  1. A-Threads A-Timeline X-Needs-Rust Z-Schedule
    jplatte
  • QA signoff on completion
  • Design signoff on completion
  • Product signoff on completion
@callumu
Copy link

callumu commented Sep 6, 2023

I have a few questions:

  1. When is the deadline for the design work on this needed?
  2. Is changing the composer placeholder text or changing anything visually in the composer out of scope? I'm unsure if this follows 'change the composer behaviour'

@manuroe
Copy link
Member Author

manuroe commented Sep 6, 2023

  1. Is changing the composer placeholder text or changing anything visually in the composer out of scope? I'm unsure if this follows 'change the composer behaviour'

It is out of scope. UX will not be great. This is why I added warnings about only power users will know it. You can sync with @amshakal to understand the logic behind.

@Velin92
Copy link
Member

Velin92 commented Sep 11, 2023

As of right now the Rust SDK is only capable of checking if a Message Like Event is threaded or not.
These are the following event types that can be threaded:

case emote
case image
case audio
case video
case file
case notice
case text
case location

This means that Stickers and Polls are out of scope as of right now

@manuroe
Copy link
Member Author

manuroe commented Sep 13, 2023

Thanks to the nice @callumu's input in figma, I removed the following from out of scope
Change the composer behavior or add specific actions to threaded messages. Only aware people will know that they can use the existing reply action to not break the thread

and added new acceptance criteria:

  • The action menu must display "Reply in Thread"
  • The composer should have the hint "Reply in Thread"

cc @ganfra @Velin92

@manuroe manuroe assigned pixlwave and unassigned ganfra, callumu, Velin92 and pixlwave Sep 15, 2023
@manuroe manuroe added X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA and removed X-Needs-Design labels Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App: ElementX Android App: ElementX iOS T-User Story Team: Element X Platform X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA
Projects
None yet
Development

No branches or pull requests

6 participants