Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Notification settings for a room #1075

Open
7 tasks done
VolkerJunginger opened this issue Mar 1, 2023 · 3 comments
Open
7 tasks done

[Story] Notification settings for a room #1075

VolkerJunginger opened this issue Mar 1, 2023 · 3 comments

Comments

@VolkerJunginger
Copy link
Contributor

VolkerJunginger commented Mar 1, 2023

As a user that is a member in a room I want to be able to configure the way I get notifications for new messages in that room so I can make sure I do not miss relevant content.

  • notifications for new messages can be configured for each room separatly
  • I can choose between: All messages, mentions & keywords only, none mute
  • the default is "notifications for all new messages" the default is defined by the current account push rules
  • The notification setting is in the room detail view.

To clarify:

  • Can we provide the option for mentions & keywords at all?
  • If yes: Keywords need to be configured global; this is not a room specific setting. We need to make this transparent to the user. Shall we show the keywords also in the setting for the room so users don't need to go back & forth between global & local settings.

Design: iOS, Android

Scope

Android

  1. A-Notifications T-Task X-Needs-Signoff
    langleyd
  2. A-Notifications T-Task X-Needs-Signoff
    langleyd
  3. A-Notifications T-Task
    yostyle

iOS

  1. A-Notifications T-Enhancement
    nimau
  2. A-Notifications T-Enhancement
    nimau
  3. A-Notifications T-Enhancement
    nimau
  4. A-Notifications T-Enhancement
  • QA signoff on completion
  • Design signoff on completion
  • Product signoff on completion

Tasks

No tasks being tracked yet.

Out of scope

@clokep
Copy link
Contributor

clokep commented Mar 1, 2023

If yes: Keywords need to be configured global; this is not a room specific setting.

It might be doable (technically) to configure keywords per room, although I don't know if that's desirable. (We would probably need to change the type of rule that we create for it, however.)

@VolkerJunginger
Copy link
Contributor Author

For now global keywords is fine. I think we should enhance the UX by also showing the (global) keywords in the room settings and give the option to change them here, too - not only in the global setting. This way the user gets a better understanding what he subscribed to.

@giomfo
Copy link
Member

giomfo commented Aug 25, 2023

@langleyd here is the update of this Story:

  • iOS: all the work has been done (thx @nimau). It is available in the nightly release behind the Developer Option "Show notification settings" (disabled by default). All my tests were ok. This platform is ready for the QA/Design signoff.

  • Android: the 3 first issues listed here are handled in the following PR. This PR has been approved but it is blocked because of some missing code coverage (see Add room notification settings element-x-android#807 (comment)). FYI, the set of screenshots has to be generated again in this PR. We decided to wait for the code coverage before updating them (because they are quickly in conflict). So we prefer generate them at the last time before merging.

cc @amshakal @VolkerJunginger

@giomfo giomfo assigned langleyd and unassigned giomfo Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants