Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best option to remove sensitive arguments from the UI? #114

Open
dedman opened this issue Aug 27, 2019 · 2 comments
Open

Best option to remove sensitive arguments from the UI? #114

dedman opened this issue Aug 27, 2019 · 2 comments

Comments

@dedman
Copy link

dedman commented Aug 27, 2019

Hey there, I was just trying to stop the UI from showing potentially sensitive arguments unnecessarily. I looked through the code and there doesn't seem to be an easy way to do this even with monkey patching so I forked and modified the job.erb like this shifthealthparadigms@8615c0d

Is that the only option or is there something I missed?

Thanks, we really appreciate the project.

@andyatkinson
Copy link
Collaborator

@dedman That seems like a nice feature to add! If you wanted to take inspiration from Rails, perhaps you could add a configuration option like:

Rails.application.config.filter_parameters += [:password]

And introduce a filter_parameters sort of array of symbols to look for, your value could be could be [:arguments], to generalize/externalize what you've done on your fork a bit.

Thoughts?

@dedman
Copy link
Author

dedman commented Aug 27, 2019

Hey @andyatkinson thanks for your response, I just submitted a PR with the basics of a config for this. #115

Sorry I couldn't get the tests running locally. Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants