Columns with zero count displaying despite option

[brienneK]

Overview

The 'Hide columns with zero count' checkbox, is not hiding columns with zero counts. The Grand Total is also not calculated.

Reproduction steps

1. Create a new report of type 'Extended Report - Event Pivot Chart'
2. Select Event Title for Select Row Fields and Event Participant Status forSelect Column Header
3. Check the 'Hide columns with zero count' checkbox
4. Click Refresh Results
5. Notice that columns with only zeros are still displayed

Current behaviour

Columns with zero counts are not hidden when the option is enabled and the Grand Total is not calculated.

Expected behaviour

If the option is enabled, columns with zero counts should not be displayed and the Grand Total be calculated.

Environment information

• CiviCRM: _5.67.0, 5.69.alpha1

Comments

I ran a git bisect and it seems like the issue is being caused by the changes in this commit

commit 82c75790103cd153d5abd29e04644a0c12733f73
Author: Eileen McNaughton <[email protected]>
Date:   Mon May 1 12:24:40 2023 +1200

    Use parent format function
    
    Parent handles more notices - will require loosening of typing

 CRM/Extendedreport/Form/Report/ExtendedReport.php | 35 +++--------------------
 1 file changed, 4 insertions(+), 31 deletions(-)
``