Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use safe-settings or probot/settings to enforce repository policies #151

Open
magnusbaeck opened this issue Nov 14, 2022 · 1 comment
Open

Comments

@magnusbaeck
Copy link
Member

Description

We should implement github.com/github/safe-settings or github.com/probot/settings to enforce the repository policies that current are maintained by hand, like "repo maintainers should also be watchers" and "two approvals are required before a merge".

Motivation

Automatically enforced policies are preferable (as long as they don't get in the way).

Exemplification

N/A

Benefits

Less work setting up a repository, easier to deal with configuration drift, fewer documentation requirements.

Possible Drawbacks

We can introduce friction if we add policies that we think should apply to all repositories but actually don't. Policy enforcement choices need to be done with care.

@magnusbaeck
Copy link
Member Author

One interesting use case for this is to enforce approval of workflow executions for PRs from external contributors. See https://www.securityweek.com/major-it-crypto-firms-exposed-to-supply-chain-compromise-via-new-class-of-ci-cd-attack/ and the minutes of the 2024-02-08 TC meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant