Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use effective date for credit card with deferred payment. #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use effective date for credit card with deferred payment. #70

wants to merge 1 commit into from

Conversation

chemtov
Copy link

@chemtov chemtov commented Mar 27, 2019

If the DTUSER is different from the DTPOSTED in an transaction then we
have a deferred payment. Use the effective date in ledger for such
case.

Closes: #69

jseutter/ofxparse#150 needs to be solved before merging this. I've tested this with jseutter/ofxparse#151 and it worked.

@chemtov chemtov force-pushed the feature/use_effective_date_for_credit_card branch from 0214d51 to d51ac1b Compare March 27, 2019 23:54
@chemtov
Use effective date for credit card with deferred payment.
7068aa0 
If the DTUSER is different from the DTPOSTED in an transaction then we
have a deferred payment. Use the effective date in ledger for such
case.

Closes: egh#69
@chemtov chemtov force-pushed the feature/use_effective_date_for_credit_card branch from d51ac1b to 7068aa0 Compare March 27, 2019 23:57
@501st-alpha1
Copy link
Contributor

So it has been almost 6 months since jseutter/ofxparse#151 was merged, and there still hasn't been a new release of ofxparse (and in fact there hasn't been since November 2018, almost 2 years ago 😬 ). @egh, would it be possible or desirable to update the version of ofxparse that ledger-autosync uses to the latest from GitHub (or a specific commit) in the meantime?

@chemtov, I'm sure the test failures are because Travis doesn't have the right version of ofxparse, but it looks like there are also some conflicts, so you may want to rebase your branch.

@egh
Copy link
Owner

egh commented Jul 25, 2020

So it has been almost 6 months since jseutter/ofxparse#151 was merged, and there still hasn't been a new release of ofxparse (and in fact there hasn't been since November 2018, almost 2 years ago grimacing ). @egh, would it be possible or desirable to update the version of ofxparse that ledger-autosync uses to the latest from GitHub (or a specific commit) in the meantime?

:( It might be possible. I've never done that with a setup.py install. I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Credit card with deferred payment are not using effective date.
3 participants
@chemtov @501st-alpha1 @egh