Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break and continue with whitespace control issue #86

Open
edgurgel opened this issue Sep 6, 2021 · 2 comments
Open

break and continue with whitespace control issue #86

edgurgel opened this issue Sep 6, 2021 · 2 comments

Comments

@edgurgel
Copy link
Owner

edgurgel commented Sep 6, 2021

     Render result was different!
     Input:
     ########################

     this should print

     {%- break -%}

     this should not print

     ########################


     code:  liquid_output == solid_output
     left:  "########################\n\nthis should print\n"
     right: "########################\n\nthis should print"
     Render result was different!
     Input:
     ########################

     this should print

     {%- continue %}

     this should not print

     ########################


     code:  liquid_output == solid_output
     left:  "########################\n\nthis should print\n"
     right: "########################\n\nthis should print"

https://github.com/edgurgel/solid/blob/master/test/integration/whitespace_control_cases/break_tag_test.exs#L3-L15
& https://github.com/edgurgel/solid/blob/master/test/integration/whitespace_control_cases/continue_tag_test.exs#L3-L15

@carlosfrodrigues
Copy link

I'd like to see this issue. Can you assign this for me?

@edgurgel
Copy link
Owner Author

edgurgel commented Oct 7, 2021

Sure! Thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants