Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer state from Zip code #134

Open
Frijol opened this issue Oct 11, 2021 · 4 comments
Open

Infer state from Zip code #134

Frijol opened this issue Oct 11, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@Frijol
Copy link
Contributor

Frijol commented Oct 11, 2021

Notebook: https://colab.research.google.com/github/edgi-govdata-archiving/ECHO-Cross-Program/blob/main/ECHO-Cross-Programs.ipynb#scrollTo=LH-8VrSTaRLN

If you are running the Notebook on a Zip code, specifying State (cell 3) is not required. However, the "state" field is used in creating graph titles. This means that it's easy to accidentally create misleading graphics, showing mislabeled/invalid locations. For example:

image

(The Zip code specified is in Washington, but Alabama is selected by default in the State dropdown, so the graph title shows an invalid location.)

There are two possible solutions:

  1. Infer the "state" field from the Zip code so that it is correct in the graphs
  2. Don't display the state when analyzing by Zip code

Option 1 seems better to me even though it adds a bit more code complexity, since it produces a more usable end result. Any opinions on that preference @ericnost @shansen5 ?

@Frijol Frijol added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Oct 11, 2021
@bhvya1505
Copy link

Hi, I would like to contribute and attempt to solve this issue. I am new to open source so I am not sure if you need to assign it to me or I can go ahead and fork. Can I work on it?

@Frijol
Copy link
Contributor Author

Frijol commented Oct 12, 2021

Please go ahead! Let us know if you have any questions.

@shansen5
Copy link
Collaborator

Yes @byvya1505, thank you for offering to help on this. Note that this notebook imports our ECHO_modules code, and you may need to look into that.
https://github.com/edgi-govdata-archiving/ECHO_modules
I haven't yet looked to see if there is a resource for mapping from zip codes to states.

@shansen5 shansen5 assigned shansen5 and bhvya1505 and unassigned shansen5 Oct 13, 2021
@Frijol
Copy link
Contributor Author

Frijol commented Oct 27, 2021

Hi @bhvya1505 are you still working on this one? Anything we can do to support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants