Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name consistency in SL.polymars #146

Open
bdwilliamson opened this issue Jan 17, 2023 · 1 comment
Open

Name consistency in SL.polymars #146

bdwilliamson opened this issue Jan 17, 2023 · 1 comment

Comments

@bdwilliamson
Copy link

For continuous outcomes, SL.polymars returns list(pred = pred, fit = list(object = fit.mars)), whereas for binary outcomes, SL.polymars returns list(pred = pred, fit = list(fit = fit.mars)). I think the former is used throughout the rest of SuperLearner, so it would be great to have the binary-outcome polymars behave similarly. Thanks!

@ecpolley
Copy link
Owner

I believe this traces back to the different polymars predict methods, polspline::predict.polymars uses object, while polymars::ppolyclass uses fit. Let me check if there would be any adverse consequences of the change to align with object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants