Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugin loading to fail #517

Open
amccaskey opened this issue Feb 17, 2022 · 7 comments
Open

Allow plugin loading to fail #517

amccaskey opened this issue Feb 17, 2022 · 7 comments
Assignees

Comments

@amccaskey
Copy link
Contributor

I think we should allow plugins to fail and if they do just throw a warning and continue loading the rest of the plugins. No reason that a plugin failing to load should mean you can't use the framework at all.

@amccaskey amccaskey self-assigned this Feb 17, 2022
@anushkrishnav
Copy link

I would like to work on the issue
Can you share more info

@1tnguyen
Copy link
Member

1tnguyen commented Jun 5, 2022

I think this is referring to the initialize method in this ServiceRegistry implementation.
Basically, we need to make the "Load plugins" loop handle the loading of plugin share libraries a bit more graciously (e.g., via try-catch, etc.) since some plugins are not mandatory and warnings are sufficient.

@anushkrishnav
Copy link

Please assign me the issue , i will start working on it

@1tnguyen
Copy link
Member

@amccaskey Have you done any work on this one? @anushkrishnav wants to work on it :)

@amccaskey
Copy link
Contributor Author

Nope. Please go ahead.

@1tnguyen 1tnguyen assigned anushkrishnav and unassigned amccaskey Jun 10, 2022
@anushkrishnav
Copy link

Awesome will start right away !!

@anushkrishnav
Copy link

A simple try-catch should be enough

try{
            context.InstallBundles(path + "/" + std::string(ent2->d_name));
            } catch (std::exception& e) {
              XACCLogger::instance()->error("Error installing bundle: " + path + "/" + std::string(ent2->d_name));
            }

or is something more expected? a task list would be really helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants