Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api/spec] Incomplete ConfigAccessor description #70

Open
jmesnil opened this issue May 28, 2018 · 2 comments
Open

[api/spec] Incomplete ConfigAccessor description #70

jmesnil opened this issue May 28, 2018 · 2 comments
Assignees

Comments

@jmesnil
Copy link
Contributor

jmesnil commented May 28, 2018

I'm integrating the ConfigAccessor to my config JSR implementation and the following concepts from ConfigAccessor spec are not explained or specified in https://github.com/eclipse/ConfigJSR/blob/master/spec/src/main/asciidoc/configaccessor.asciidoc#configaccessor:

  • withCurrentProjectStage(boolean with) does not define what a project state is.
  • strictly(boolean strictly) has a local link for property value resolution sequence that does not exist.
  • parameterizedBy(String propertyName) has a local link for ConfigResolver.getPropertyAwarePropertyValue that does not exist

There is also disprecancy between the spec and the API.
The ConfigAccessor does not define some methods specified in the spec (e.g. withCurrentProjectStage, strictly) while some in the interface are not mentioned (e.g. withLookupChain).

The Javadoc of withLookupChain mentions a javaconfig.projectStage property that is not defined anywhere. Is the name of this property significant (I assume it is since it starts with javaconfig).

@struberg
Copy link
Contributor

Right, withProjectStage should be removed. It's a left-over from DeltaSpike.
We could probably introduce a common property javax.config.projectStage or so.

But in that case you would use withLookupChain("${javax.config.projectStage}") to make Config use a ".Production" or ".Development" postfix lookup.

@struberg struberg self-assigned this Jun 28, 2018
struberg added a commit that referenced this issue Jun 28, 2018
Also includes finishing the rename from ConfigValue to ConfigAccessor
struberg added a commit that referenced this issue Jun 28, 2018
struberg added a commit to struberg/ConfigJSR-1 that referenced this issue Mar 13, 2019
struberg added a commit to struberg/ConfigJSR-1 that referenced this issue Mar 13, 2019
struberg added a commit that referenced this issue Mar 20, 2019
@struberg
Copy link
Contributor

@jmesnil the spec paper should now be in a much better shape. Can you please review if all is resolved? txs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants