-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api/spec] Incomplete ConfigAccessor description #70
Comments
Right, withProjectStage should be removed. It's a left-over from DeltaSpike. But in that case you would use |
Also includes finishing the rename from ConfigValue to ConfigAccessor
@jmesnil the spec paper should now be in a much better shape. Can you please review if all is resolved? txs! |
I'm integrating the ConfigAccessor to my config JSR implementation and the following concepts from ConfigAccessor spec are not explained or specified in https://github.com/eclipse/ConfigJSR/blob/master/spec/src/main/asciidoc/configaccessor.asciidoc#configaccessor:
withCurrentProjectStage(boolean with)
does not define what a project state is.strictly(boolean strictly)
has a local link forproperty value resolution sequence
that does not exist.parameterizedBy(String propertyName)
has a local link forConfigResolver.getPropertyAwarePropertyValue
that does not existThere is also disprecancy between the spec and the API.
The
ConfigAccessor
does not define some methods specified in the spec (e.g.withCurrentProjectStage
,strictly
) while some in the interface are not mentioned (e.g.withLookupChain
).The Javadoc of
withLookupChain
mentions ajavaconfig.projectStage
property that is not defined anywhere. Is the name of this property significant (I assume it is since it starts withjavaconfig
).The text was updated successfully, but these errors were encountered: