Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

td-json-open assertion exists multiple times #124

Open
adriankast opened this issue Jul 17, 2020 · 5 comments
Open

td-json-open assertion exists multiple times #124

adriankast opened this issue Jul 17, 2020 · 5 comments
Labels
assertions topics about the assertions package

Comments

@adriankast
Copy link
Contributor

Due to the multiple usage of td-json-open and child assertions of it (td-json-open_xyz) in both automatic and manual assertions it is not merged correctly, which results in 337 assertions if a single TD is assertion tested. If multiple TDs are under test, the result merge probably also merges the duplicates and 335 assertions are reported.

@egekorkan
Copy link
Member

@adriankast this is now fixed right?

@adriankast
Copy link
Contributor Author

No, this was the issue we agreed to not fix at first but just write an issue, since you meant that this is kind of an structural problem an shouldn't just be "Bugfixed"

@FadySalama
Copy link
Contributor

This assertion is causing problems for automatic generation of manual.csv! @egekorkan We should talk about it

@egekorkan
Copy link
Member

I remember this discussion. It stems from the following part in the TD spec:

image

This is annoying since the first one (parent assertion)

I will open an issue about it, not sure why I did not do it before already.

Regarding automatic generation of manual.csv, @FadySalama you can do a hacky solution for now by ignoring the children assertions, i.e. removing the children assertions in the input csv

@egekorkan
Copy link
Member

also see w3c/wot-thing-description#1511

@egekorkan egekorkan added the assertions topics about the assertions package label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assertions topics about the assertions package
Projects
None yet
Development

No branches or pull requests

3 participants