Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] proposed mappedEditProviders API updated in vscode 1.95 #14451

Open
Tracked by #14403
rschnekenbu opened this issue Nov 14, 2024 · 0 comments · May be fixed by #14453
Open
Tracked by #14403

[vscode] proposed mappedEditProviders API updated in vscode 1.95 #14451

rschnekenbu opened this issue Nov 14, 2024 · 0 comments · May be fixed by #14453
Assignees
@rschnekenbu
Labels
vscode issues related to VSCode compatibility

Comments

@rschnekenbu
Copy link
Contributor

rschnekenbu commented Nov 14, 2024 •
edited
Loading

as documented by #14399, mappedEditProviders proposed API has evolved with VS Code 1.95. This API is used by Typescript builtins and may need some evolution.

  • The type of the property codeBlocks of the interface MappedEditsRequest now has an additional optional markdownBeforeBlock
  • Some eslint ignored rules comments were added
  • readonly result?: ChatResult property has been added to ConversationResponse
@rschnekenbu rschnekenbu added the vscode issues related to VSCode compatibility label Nov 14, 2024
@rschnekenbu rschnekenbu self-assigned this Nov 14, 2024
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Nov 14, 2024
@rschnekenbu
feat: update proposed API MappedEditProviders
0ba7f66 
fix: eclipse-theia#14451

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <[email protected]>
@rschnekenbu rschnekenbu linked a pull request Nov 14, 2024 that will close this issue
Open
1 task
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Nov 14, 2024
@rschnekenbu
feat: update proposed API MappedEditProviders
d1aaba6 
fix: eclipse-theia#14451

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <[email protected]>
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Nov 14, 2024
@rschnekenbu
feat: update proposed API MappedEditProviders
fb2d508 
fix: eclipse-theia#14451

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <[email protected]>
@rschnekenbu rschnekenbu mentioned this issue Nov 14, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rschnekenbu rschnekenbu

Labels
vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: update proposed API MappedEditProviders eclipsesource/theia
1 participant
@rschnekenbu