Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent Playwright test failures in theia-notebook-editor.test #14450

Open
planger opened this issue Nov 14, 2024 · 3 comments
Open

Intermittent Playwright test failures in theia-notebook-editor.test #14450

planger opened this issue Nov 14, 2024 · 3 comments
Assignees
Labels
notebook issues related to notebooks playwright issues related to playwright tests

Comments

@planger
Copy link
Contributor

planger commented Nov 14, 2024

I'm monitoring the stability of the Playwright tests and observed that there are a number of intermittent, recurring test failures at the theia-notebook-editor.test.ts.

Error:   1) ../../src/tests/theia-notebook-editor.test.ts:98:9 › Theia Notebook Editor interaction › should split cell 
    Error: elementHandle.waitForElementState: Element is not attached to the DOM
    Call log:
      -   waiting for element to be visible


      111 |         */
      112 |         const line = await cell.editor.lineByLineNumber(1);
    > 113 |         await line?.waitForElementState('visible');
          |                     ^
      114 |         await line?.click();
      115 |         await line?.press('ArrowRight');
      116 |

        at /home/runner/work/theia/theia/examples/playwright/src/tests/theia-notebook-editor.test.ts:113:21

It is not alarmingly frequent, but it might be good to look into it anyway to avoid false-positives.

@planger planger added playwright issues related to playwright tests notebook issues related to notebooks labels Nov 14, 2024
@planger
Copy link
Contributor Author

planger commented Nov 14, 2024

@dhuebner Would you be able to see if we can avoid these failures? Thanks a lot in advance!

@dhuebner
Copy link
Member

@planger
Sure, I will take a look. Thank you for reporting!

@dhuebner
Copy link
Member

@planger
I was not able to reproduce it locally :(
I've prepared a PR #14457 that removes the visible check and adds some logging to see the line Element state. If the test fails again, I hope I can narrow down the cause. In the test reports it is obvious that all cell-editor lines are visible when the test was failing. See attached report.

playwright-test-results-3.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks playwright issues related to playwright tests
Projects
None yet
Development

No branches or pull requests

2 participants