Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if getTodoIdentifier can be removed. #585

Closed
lepokle opened this issue Jul 18, 2019 · 1 comment
Closed

Check if getTodoIdentifier can be removed. #585

lepokle opened this issue Jul 18, 2019 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@lepokle
Copy link
Contributor

lepokle commented Jul 18, 2019

PR #517 removed the todoid from the todos. However it has still to be checked which parts of the code can be removed as well.

See comments for more information: https://github.com/eclipse/sw360/pull/517/files#diff-a06e606f8c3ddf41748827fc37910bc8L75.

@mcjaeger mcjaeger added the bug Something isn't working label Mar 5, 2020
@mcjaeger mcjaeger added this to the Backlog milestone Mar 5, 2020
@mcjaeger
Copy link
Contributor

Hm, discussion in the PR https://github.com/eclipse/sw360/pull/517/files#diff-a06e606f8c3ddf41748827fc37910bc8L75 I have almost forgotten (very special for me).

However, I think the implementation was dropped and rewritten later as it turned out to be unusable or not the shape to be corrected. Can close this issue as well then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants