Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logged NPE in ViewerUpdateMonitor constructor #1500 #1508

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mx990
Copy link

@mx990 mx990 commented Aug 14, 2024

There is a logged NPE in the constructor of ViewerUpdateMonitor when viewerInput is null. This can happen sporadically when updating tree elements during Viewer.setInput(null).

This PR adds a check to avoid creating children updates when the viewer input is null.

Fixes #1500

There is a logged NPE in the constructor of ViewerUpdateMonitor when
viewerInput is null. This can happen sporadically when updating tree
elements during Viewer.setInput(null).

This commit adds a check to avoid creating children updates when the
viewer input is null.

Fixes eclipse-platform#1500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logged NPE in ViewerUpdateMonitor constructor
1 participant