Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog tray taking wider width than the wizard when we maximise the wizard dialog. It can't be customised. #2663

Open
2 tasks done
divzz95 opened this issue Jan 6, 2025 · 4 comments
Labels
bug Something isn't working needinfo

Comments

@divzz95
Copy link

divzz95 commented Jan 6, 2025

Let's make sure issue is not already fixed in latest builds first.

Steps to reproduce

From a fresh installation and clean workspace:

  • Open any object wizard. eg. Java class
  • Click on Help icon at the bottom left.
  • Now maximise the wizard.
  • Help tray can be seen taking wider area.

I tried

  • To customise the ResizeListener added in TrayDialog.java in my subclass
  • But, it is private and final.
  • I need to use the tray dialog for my customised requirement and I am not able to change the resize behaviour.

I expected: The size of the tray dailog can be scaled as per our requirement

But got: Not able to customise the resize code.

Tested under this environment:

  • OS & version: Windows 11
  • Eclipse IDE/Platform version : 2024-12 (4.34)

Regular size wizard

regular dialog

Maximized wizard

maximised dialog

Community

  • I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.
@divzz95 divzz95 added the bug Something isn't working label Jan 6, 2025
@divzz95 divzz95 changed the title Help tray taking wider width when we maximise the wizard dialog can't be customised. Help tray taking wider width when we maximise the wizard dialog. It can't be customised. Jan 6, 2025
@jukzi
Copy link
Contributor

jukzi commented Jan 6, 2025

i do not fully understand the issue

  • Help tray can be seen taking wider area.

"wider" then what? it would help to understand the issue if you draw your expectations into the screenshots.

To customise the ResizeListener added in TrayDialog.java in my subclass

If its only a problem of you custom subclass you should provide a PR with a suggestion how to give you the needed API.

@jukzi jukzi added the needinfo label Jan 6, 2025
@mickaelistria
Copy link
Contributor

Out of curiosity, what behavior would you like to implement instead of the default one?

@divzz95
Copy link
Author

divzz95 commented Jan 6, 2025

I am reusing the Tray dialog to show some UI content when clicked on the button which is added next to help button. In this case, when I maximise the wizard, I don't want the dialog tray to take the wider area than the wizard area. How can I achieve this.?

I updated the title for better understanding.

@divzz95 divzz95 changed the title Help tray taking wider width when we maximise the wizard dialog. It can't be customised. Dialog tray taking wider width than the wizard when we maximise the wizard dialog. It can't be customised. Jan 6, 2025
@mickaelistria
Copy link
Contributor

OK, so you're showing different content then (ie not the help, but some browser or whatever else control).
Have you tried adding another ResizeListener on your dialog? If this resizeListener is added after the default one, then it can override the behavior (eg change some preferredSize on the layout and then call requestLayout to refresh)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needinfo
Projects
None yet
Development

No branches or pull requests

3 participants