Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e4] provide injection for IDialogSettingsProvider #2482

Open
laeubi opened this issue Nov 3, 2024 · 0 comments
Open

[e4] provide injection for IDialogSettingsProvider #2482

laeubi opened this issue Nov 3, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@laeubi
Copy link
Contributor

laeubi commented Nov 3, 2024

Currently the only way to obtain a IDialogSettingsProvider seem to be by calling org.eclipse.ui.PlatformUI.getDialogSettingsProvider(Bundle) but this is E3 API and require a running workbench.

This actually already calls into E4 land by using org.eclipse.e4.ui.internal.workbench.swt.DialogSettingsProviderService but that's all internal.

To make this usable outside E3 also in plain E4 RCP applications the following should be done:

  1. Have an IDialogSettingsProviderService that has method IDialogSettingsProviderService#getDialogSettingsProvider and is published in the OSGi-Service Factory, this then would also allow to handel all the currently static parts with proper OSGi-DS injections, e.g currently tracked bundles and the event listeners are never cleaned up!
  2. Allow to @Inject IDialogSettingsProvider provider into E4 Components by having a context function. Such context function should then be implemented as a ServiceFactory so it supply a proper object per bundle if used in an E4 component.
@laeubi laeubi added the enhancement New feature or request label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant