Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rendering artifacts with swt.autoScale=quarter at particular zoom levels #196

Open
HeikoKlare opened this issue Jan 20, 2025 · 3 comments · Fixed by eclipse-platform/eclipse.platform.swt#1761 · May be fixed by eclipse-platform/eclipse.platform.swt#1762
Open

Rendering artifacts with swt.autoScale=quarter at particular zoom levels #196

HeikoKlare opened this issue Jan 20, 2025 · 3 comments · Fixed by eclipse-platform/eclipse.platform.swt#1761 · May be fixed by eclipse-platform/eclipse.platform.swt#1762
Assignees
@akoch-yatta
Labels
HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT
Milestone
4.35 M3

Comments

@HeikoKlare
Copy link
Contributor

At particular zoom levels, some custom rendered widgets, such as the StyledText, show artifacts (black lines) as some areas are not rendered because of rounding issues when using swt.autoScale=quarter (or exact).

For example, starting an IDE at 175% zoom with monitor-specific scaling (or also just with swt.autoScale configured accordingly) and opening any Java editor, looks like this:

Image

The goal of this is to analyze which widgets may be affected by such issues and to find places in the code in which values are not properly rounded and need to be adapted. Those places shall be corrected.
@HeikoKlare HeikoKlare added this to HiDPI Jan 20, 2025
@HeikoKlare HeikoKlare converted this from a draft issue Jan 20, 2025
@HeikoKlare HeikoKlare added SWT Issue for SWT HiDPI A HiDPI-Related Issue or Feature labels Jan 20, 2025
@HeikoKlare HeikoKlare added this to the 4.35 M3 milestone Jan 20, 2025
@akoch-yatta akoch-yatta moved this from 🔖 Ready: Atomic to 🏗 In Work: Short in HiDPI Jan 24, 2025
@akoch-yatta akoch-yatta self-assigned this Jan 24, 2025
@akoch-yatta
Copy link

eclipse-platform/eclipse.platform.swt#1761 will cover the issue in StyledText

This was linked to pull requests Jan 24, 2025
[win32] Scale up bounds as rectangle in GC eclipse-platform/eclipse.platform.swt#1762
Draft
[win32] Scale up bounds as rectangle in canvas eclipse-platform/eclipse.platform.swt#1761
Merged
@akoch-yatta
Copy link

eclipse-platform/eclipse.platform.swt#1762 will cover the issue in GC

@akoch-yatta
Copy link

Remaining places to check:

  • Path::addArc
  • Region::intersects
  • Canvas::scroll
  • Composite::drawBackground
  • Control::redraw
  • Control::setBounds
  • Scrollable::computeTrim

@github-project-automation github-project-automation bot moved this from 🏗 In Work: Short to ✅ Done in HiDPI Jan 24, 2025
@HeikoKlare HeikoKlare reopened this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akoch-yatta akoch-yatta

Labels
HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT
Projects
HiDPI
Status: ✅ Done
Milestone
4.35 M3
2 participants
@HeikoKlare @akoch-yatta