Build: I20231221-1800 Unstable #1686

iloveeclipse · 2023-12-22T06:51:21Z

Build: I20231221-1800 has comparator errors.

1.  equinox/bundles/org.eclipse.osgi/pom.xml
   no-classifier: different
      org/eclipse/osgi/internal/framework/SystemBundleActivator.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

2.  eclipse.platform.ui/bundles/org.eclipse.e4.ui.css.core/.polyglot.META-INF
   no-classifier: different
      org/eclipse/e4/ui/css/core/dom/properties/css2/AbstractCSSPropertyTextHandler.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

3.  eclipse.platform.ui/bundles/org.eclipse.e4.ui.css.swt/.polyglot.META-INF
   no-classifier: different
      org/eclipse/e4/ui/css/swt/dom/WidgetElement.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

4.  eclipse.platform/runtime/bundles/org.eclipse.core.expressions/.polyglot.META-INF
   no-classifier: different
      org/eclipse/core/internal/expressions/StandardElementHandler.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

5.  eclipse.platform.ui/bundles/org.eclipse.ui.workbench/.polyglot.META-INF
   no-classifier: different
      org/eclipse/ui/SelectionEnabler.class: different
      org/eclipse/ui/internal/ExtensionEventHandler.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

6.  eclipse.platform/ua/org.eclipse.ui.cheatsheets/pom.xml
   no-classifier: different
      org/eclipse/ui/internal/cheatsheets/data/CheatSheetParser.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

7.  eclipse.platform.ui/bundles/org.eclipse.text/.polyglot.META-INF
   no-classifier: different
      org/eclipse/jface/text/templates/TemplateTranslator.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

8.  eclipse.platform.ui/bundles/org.eclipse.ui.workbench.texteditor/.polyglot.META-INF
   no-classifier: different
      org/eclipse/ui/texteditor/AbstractTextEditor.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

9.  eclipse.jdt.debug/org.eclipse.jdt.launching/pom.xml
   no-classifier: different
      org/eclipse/jdt/internal/launching/environments/EnvironmentsManager.class: different
      org/eclipse/jdt/launching/JavaRuntime.class: different
      org/eclipse/jdt/launching/StandardSourcePathProvider.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

10.  eclipse.pde/ui/org.eclipse.pde.core/.polyglot.META-INF
   no-classifier: different
      org/eclipse/pde/internal/core/builders/PluginBaseErrorReporter.class: different
      org/eclipse/pde/internal/core/feature/Feature.class: different
      org/eclipse/pde/internal/core/schema/Schema.class: different
      org/eclipse/pde/internal/core/site/Site.class: different
      org/eclipse/pde/internal/core/target/TargetPersistence35Helper.class: different
      org/eclipse/pde/internal/core/target/TargetPersistence36Helper.class: different
      org/eclipse/pde/internal/core/target/TargetPersistence38Helper.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

11.  eclipse.jdt.ui/org.eclipse.jdt.junit.core/.polyglot.META-INF
   no-classifier: different
      org/eclipse/jdt/internal/junit/buildpath/JUnitContainerInitializer.class: different
      org/eclipse/jdt/internal/junit/model/TestRunHandler.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

12.  eclipse.jdt.ui/org.eclipse.jdt.junit/.polyglot.META-INF
   no-classifier: different
      org/eclipse/jdt/internal/junit/ui/JUnitQuickFixProcessor.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

13.  eclipse.platform/debug/org.eclipse.unittest.ui/.polyglot.META-INF
   no-classifier: different
      org/eclipse/unittest/internal/junitXmlReport/TestRunHandler.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

14.  eclipse.pde/apitools/org.eclipse.pde.api.tools/.polyglot.META-INF
   no-classifier: different
      lib/apitooling-ant.jar: different
         org/eclipse/pde/api/tools/internal/tasks/APIFreezeReportConversionTask$ConverterDefaultHandler.class: different
      org/eclipse/pde/api/tools/internal/ApiDescriptionManager.class: different
      org/eclipse/pde/api/tools/internal/search/UseScanParser.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

15.  eclipse.pde/ui/org.eclipse.pde.ui/.polyglot.META-INF
   no-classifier: different
      org/eclipse/pde/internal/ui/editor/category/CategoryDetailsSection.class: different
      org/eclipse/pde/internal/ui/editor/plugin/OverviewPage.class: different
      org/eclipse/pde/internal/ui/editor/product/OverviewPage.class: different
      org/eclipse/pde/internal/ui/editor/site/CategoryDetailsSection.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

16.  eclipse.pde/ua/org.eclipse.pde.ua.core/.polyglot.META-INF
   no-classifier: different
      org/eclipse/pde/internal/ua/core/cheatsheet/comp/CompCSTaskObject.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

17.  rt.equinox.p2/bundles/org.eclipse.equinox.p2.director.app/.polyglot.META-INF
   no-classifier: different
      org/eclipse/equinox/internal/p2/director/app/IUListFormatter.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

Could be related to eclipse-jdt/eclipse.jdt.core#1773, I'm looking into it.

The text was updated successfully, but these errors were encountered:

merks · 2023-12-22T06:57:56Z

It seems like comparator errors are a semi-daily occurrence. 😱 Thank you for your diligence dealing with such issues: 🏅

iloveeclipse · 2023-12-22T07:42:17Z

OK, looks like in all cases I've checked line number table was changed in code that contained switch cases. it seems there were few more local variable slots computed now, before less, so the numbering of local variables and stack size changed, like here in the org.eclipse.pde.internal.core.feature.Feature.parse(Node) method:

@srikanth-sankaran, I assume this is expected side effect of eclipse-jdt/eclipse.jdt.core#1773 ?

See eclipse-platform/eclipse.platform.releng.aggregator#1686

srikanth-sankaran · 2023-12-22T07:48:50Z

Studying ...

See eclipse-platform/eclipse.platform.releng.aggregator#1686

See eclipse-platform#1686

See eclipse-platform/eclipse.platform.releng.aggregator#1686

iloveeclipse · 2023-12-22T08:05:05Z

I've prepared PR's to touch bundles if needed:

PDE Touch bundles affected by changed compiler generation for switch eclipse-pde/eclipse.pde#1028
Platform UI Touch bundles affected by changed compiler generation for switch eclipse.platform.ui#1451
Platform Touch bundles affected by changed compiler generation for switch eclipse.platform#1066
JDT UI Touch bundles affected by changed compiler generation for switch eclipse-jdt/eclipse.jdt.ui#1031
P2 Touch bundles affected by changed compiler generation for switch eclipse-equinox/p2#419
Equinox Touch bundles affected by changed compiler generation for switch eclipse-equinox/equinox#459
JDT Core Touch bundles affected by changed compiler generation for switch eclipse-jdt/eclipse.jdt.core#1780

and a small fix for TouchBundles script (to handle PDE repo if differently named locally)

Small fix for TouchBundles to properly touch PDE #1687

srikanth-sankaran · 2023-12-22T08:08:23Z

I've prepared PR's to touch bundles if needed:

PDE Touch bundles affected by changed compiler generation for switch eclipse-pde/eclipse.pde#1028

Platform UI Touch bundles affected by changed compiler generation for switch eclipse.platform.ui#1451

Platform Touch bundles affected by changed compiler generation for switch eclipse.platform#1066

JDT UI Touch bundles affected by changed compiler generation for switch eclipse-jdt/eclipse.jdt.ui#1031

P2 Touch bundles affected by changed compiler generation for switch eclipse-equinox/p2#419

Equinox Touch bundles affected by changed compiler generation for switch eclipse-equinox/equinox#459

and a small fix for TouchBundles script (to handle PDE repo if differently named locally)

Small fix for TouchBundles to properly touch PDE #1687

Is this list supposed to be exhaustive ? How come it doesn't include jdt.core ?? I see one comparator diff in WrapPreparator which is what I am looking at presently to see if the changes are justified.

srikanth-sankaran · 2023-12-22T08:11:53Z

Are the class files themselves readily accessible ? The textual diff is not completely informative. For example the local variable table is missing. I am looking to get my hands on org.eclipse.jdt.internal.formatter.linewrap.WrapPreparator.class for baseline and build

See eclipse-platform/eclipse.platform.releng.aggregator#1686

iloveeclipse · 2023-12-22T08:23:58Z

Is this list supposed to be exhaustive ?

Yes

How come it doesn't include jdt.core ?? I see one comparator diff in WrapPreparator

Interesting. This class diff contained in the class artifacts but not in the overview diff above. Now it is touched via eclipse-jdt/eclipse.jdt.core#1780 .

Are the class files themselves readily accessible ?

Yes, if you download https://download.eclipse.org/eclipse/downloads/drops4/I20231221-1800/ you will get the "old" classes.
If you use that SDK for your workspace, you will get "new" classes for projects imported in your workspace.

iloveeclipse · 2023-12-22T08:42:27Z

Are the class files themselves readily accessible ? The textual diff is not completely informative. For example the local variable table is missing.

I've created #1688.

See #1686

srikanth-sankaran · 2023-12-22T10:03:00Z

@srikanth-sankaran, I assume this is expected side effect of eclipse-jdt/eclipse.jdt.core#1773 ?

OK, I have studied a handful of cases. This is a result of eclipse-jdt/eclipse.jdt.core#1773 - This is not an expected side effect. This is not harmful for correctness - the local variable slots are simply wasted - but needs be rectified.

Basically, the compiler will add two unnamed secret variables per each classic string switch that also declares some other local in one of the case blocks

I'll propose a patch shortly.

srikanth-sankaran · 2023-12-22T10:11:13Z

I have raised eclipse-jdt/eclipse.jdt.core#1782

srikanth-sankaran · 2023-12-22T10:44:34Z

I have raised eclipse-jdt/eclipse.jdt.core#1782

PR under test: eclipse-jdt/eclipse.jdt.core#1784

srikanth-sankaran · 2023-12-22T11:23:29Z

I have raised eclipse-jdt/eclipse.jdt.core#1782

PR under test: eclipse-jdt/eclipse.jdt.core#1784

This is merged in - I'll check back tomorrow to see if any further action is required.

iloveeclipse · 2023-12-22T11:25:01Z

https://ci.eclipse.org/releng/job/Builds/job/I-build-4.31/56/ started

iloveeclipse · 2023-12-22T12:52:12Z

https://ci.eclipse.org/releng/job/Builds/job/I-build-4.31/56/ started

... and successfully finished:

https://download.eclipse.org/eclipse/downloads/drops4/I20231222-0620/

@srikanth-sankaran : many thanks for a quick fix!

I will close now opened PR's, they are not needed anymore.

PS:
I will have no access to any PC from 24.12 to 04.01, so in case some changes in platform would be needed, please contact @trancexpress.

iloveeclipse added bug Something isn't working regression Regression defect labels Dec 22, 2023

iloveeclipse added a commit to iloveeclipse/eclipse.pde.ui that referenced this issue Dec 22, 2023

Touch bundles affected by changed compiler generation for switch

dab1a1f

See eclipse-platform/eclipse.platform.releng.aggregator#1686

This was referenced Dec 22, 2023

Touch bundles affected by changed compiler generation for switch eclipse-pde/eclipse.pde#1028

Closed

Touch bundles affected by changed compiler generation for switch eclipse-platform/eclipse.platform#1066

Closed

iloveeclipse added a commit to iloveeclipse/eclipse.platform that referenced this issue Dec 22, 2023

Touch bundles affected by changed compiler generation for switch

5c305d8

See eclipse-platform/eclipse.platform.releng.aggregator#1686

iloveeclipse added a commit to iloveeclipse/eclipse.platform.ui that referenced this issue Dec 22, 2023

Touch bundles affected by changed compiler generation for switch

29c7d18

See eclipse-platform/eclipse.platform.releng.aggregator#1686

iloveeclipse mentioned this issue Dec 22, 2023

Touch bundles affected by changed compiler generation for switch eclipse-platform/eclipse.platform.ui#1451

Closed

iloveeclipse added a commit to iloveeclipse/eclipse.platform.releng.aggregator that referenced this issue Dec 22, 2023

Small fix for TouchBundles to properly touch PDE

6382af2

See eclipse-platform#1686

iloveeclipse mentioned this issue Dec 22, 2023

Small fix for TouchBundles to properly touch PDE #1687

Merged

iloveeclipse added a commit to iloveeclipse/p2 that referenced this issue Dec 22, 2023

Touch bundles affected by changed compiler generation for switch

ff284cb

See eclipse-platform/eclipse.platform.releng.aggregator#1686

This was referenced Dec 22, 2023

Touch bundles affected by changed compiler generation for switch eclipse-equinox/p2#419

Closed

Touch bundles affected by changed compiler generation for switch eclipse-jdt/eclipse.jdt.ui#1031

Closed

iloveeclipse added a commit to iloveeclipse/eclipse.jdt.ui that referenced this issue Dec 22, 2023

Touch bundles affected by changed compiler generation for switch

91ea321

See eclipse-platform/eclipse.platform.releng.aggregator#1686

iloveeclipse added a commit to iloveeclipse/equinox that referenced this issue Dec 22, 2023

Touch bundles affected by changed compiler generation for switch

d39c43e

See eclipse-platform/eclipse.platform.releng.aggregator#1686

iloveeclipse mentioned this issue Dec 22, 2023

Touch bundles affected by changed compiler generation for switch eclipse-equinox/equinox#459

Closed

iloveeclipse added a commit to iloveeclipse/eclipse.jdt.core that referenced this issue Dec 22, 2023

Touch bundles affected by changed compiler generation for switch

a8aa88b

See eclipse-platform/eclipse.platform.releng.aggregator#1686

iloveeclipse mentioned this issue Dec 22, 2023

Touch bundles affected by changed compiler generation for switch eclipse-jdt/eclipse.jdt.core#1780

Closed

iloveeclipse mentioned this issue Dec 22, 2023

Enhance class file comparator diff report #1688

Open

iloveeclipse added a commit that referenced this issue Dec 22, 2023

Small fix for TouchBundles to properly touch PDE

ccc1062

See #1686

iloveeclipse closed this as completed Dec 22, 2023

iloveeclipse assigned srikanth-sankaran Dec 22, 2023

iloveeclipse added this to the 4.31 M1 milestone Dec 22, 2023

srikanth-sankaran mentioned this issue Jan 24, 2024

Comparator Errors in I20240123-1800 #1744

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build: I20231221-1800 Unstable #1686

Build: I20231221-1800 Unstable #1686

iloveeclipse commented Dec 22, 2023

merks commented Dec 22, 2023

iloveeclipse commented Dec 22, 2023 •

edited

Loading

srikanth-sankaran commented Dec 22, 2023

iloveeclipse commented Dec 22, 2023 •

edited

Loading

srikanth-sankaran commented Dec 22, 2023

srikanth-sankaran commented Dec 22, 2023 •

edited

Loading

iloveeclipse commented Dec 22, 2023

iloveeclipse commented Dec 22, 2023

srikanth-sankaran commented Dec 22, 2023

srikanth-sankaran commented Dec 22, 2023

srikanth-sankaran commented Dec 22, 2023

srikanth-sankaran commented Dec 22, 2023 •

edited

Loading

iloveeclipse commented Dec 22, 2023

iloveeclipse commented Dec 22, 2023

Build: I20231221-1800 Unstable #1686

Build: I20231221-1800 Unstable #1686

Comments

iloveeclipse commented Dec 22, 2023

merks commented Dec 22, 2023

iloveeclipse commented Dec 22, 2023 • edited Loading

srikanth-sankaran commented Dec 22, 2023

iloveeclipse commented Dec 22, 2023 • edited Loading

srikanth-sankaran commented Dec 22, 2023

srikanth-sankaran commented Dec 22, 2023 • edited Loading

iloveeclipse commented Dec 22, 2023

iloveeclipse commented Dec 22, 2023

srikanth-sankaran commented Dec 22, 2023

srikanth-sankaran commented Dec 22, 2023

srikanth-sankaran commented Dec 22, 2023

srikanth-sankaran commented Dec 22, 2023 • edited Loading

iloveeclipse commented Dec 22, 2023

iloveeclipse commented Dec 22, 2023

iloveeclipse commented Dec 22, 2023 •

edited

Loading

iloveeclipse commented Dec 22, 2023 •

edited

Loading

srikanth-sankaran commented Dec 22, 2023 •

edited

Loading

srikanth-sankaran commented Dec 22, 2023 •

edited

Loading