Replies: 9 comments 1 reply
-
+1 to that. Even the other open PR eclipse-platform/eclipse.platform.common#131 in the repo is an example of lack of verification at the original PR time, leading to needing to do it on a post-release manner, after being reported by end users. |
Beta Was this translation helpful? Give feedback.
-
+1, makes sense. |
Beta Was this translation helpful? Give feedback.
-
Sounds good. |
Beta Was this translation helpful? Give feedback.
-
It's certainly more logical for PDE and JDT to host their own documentation... |
Beta Was this translation helpful? Give feedback.
-
If any of you think items can be moved elsewhere, please go on ;-) But if you look at the buildscripts several things currently prevent this as they contain a lot of cross-references and as explained they actually aggregate different stuff. Nerveless merging the repositories does not prevent this if we see that some itmes might me moved , e.g. org.eclipse.jdt.tips.user and org.eclipse.platform.doc.tips seems like a standalone bundle. |
Beta Was this translation helpful? Give feedback.
-
Yes, the structure is somehow quite illogical. E.g., p2 defines org.eclipse.equinox.internal.p2.ui.IProvHelpContextIds.TRUST_DIALOG and if I have just p2 in my workspace, I search and cannot find where that is defined. Only in my full SDK workspace can I find it: So if I want to write documentation and test it, I need another Git repo. Note that Equinox is lumped in Platform, so moving this part to p2's repo is not a trivial exercise that we'd all like done, though preferably done by someone else who has nothing better to do. 😈 So I agree @laeubi that moving this into the aggregator does not prevent any subsequent refactoring in the future nor does it make such refactoring more difficult in the future. |
Beta Was this translation helpful? Give feedback.
-
CC @vogella maybe something for your merge-one-repository-a-release agenda ... |
Beta Was this translation helpful? Give feedback.
-
@vogella do you like to initiate this merge? |
Beta Was this translation helpful? Give feedback.
-
This has been done. |
Beta Was this translation helpful? Give feedback.
-
Despite its name eclipse.platform.common does not really contains any common code or something that could be shared, it actually aggregates the documentation of many projects.
Even worse, there is no verification builds, so changes can only be merged on best effort basis (e.g. eclipse-platform/eclipse.platform.common#138)
Because of this, I think it would be good to merge this repo into this one to:
as the repository is already part of this by using git-submodules, neither buildtime not build scripts will change and we can get rid of another repository.
WDYT @akurtakov @vogella @iloveeclipse ... and probably others!
Beta Was this translation helpful? Give feedback.
All reactions