Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong SVGs #101

Closed
Michael5601 opened this issue Oct 20, 2024 · 3 comments
Closed

Fix wrong SVGs #101

Michael5601 opened this issue Oct 20, 2024 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Michael5601
Copy link
Contributor

Michael5601 commented Oct 20, 2024

As part of my analysis for introducing vector graphics in Eclipse, I discovered several SVGs that either contain issues or do not align with their corresponding PNGs. Fortunately, all these issues can be resolved by adjusting the SVG files themselves, eliminating the need for a pull request outside the eclipse.platform.images repository.

The following SVGs are problematic:

  1. pinned_ovr.svg in org.eclipse.e4.ui.workbench.renderers.swt:

    • The PNG version is a different icon from the SVG. Upon opening the SVG in Inkscape, three distinct icons are displayed—one matches the PNG, while another is the one shown in the SVG. The current image area is set to display the SVG icon. The SVG needs to be changed so that the correct icon is in the image area and the others are deleted.

    PNG:
    pinned_ovr

    SVG:
    pinned_ovr2

    SVG opened in Inkscape:
    three icons

  2. build_exec.svg in org.eclipse.pde.ui\icons\etool16 and its duplicate in org.eclipse.ui.ide\icons\full\etool16:

    • When opening either of these SVGs in Inkscape, you’ll notice that the text isn't converted to a path. As a result, different rasterizers will render the text using default fonts, leading to inconsistencies. This can be fixed by converting the text to a path with a single click. I dont know if there are other duplicates with a different name that have the same issue because these two Icons differ slightly so the duplicates can't be found by automatically comparing pixel values. However, the duplicate in org.eclipse.pde.ui\icons\obj16 with the same name does not have this issue.

    Icon displayed in Chrome (or rasterized with Batik):
    image

    SVG opened in Inkscape:
    path

  3. participant_rem.svg in org.eclipse.team.ui\icons\full\elcl16:

    • When viewed in Inkscape, Chrome, or rasterized with most other rasterizers, the image appears compressed in height compared to the PNG. The PNG fits other SVGs like rem_co.svg in org.eclipse.debug.ui\icons\full\elcl16 and it's duplicate in org.eclipse.ui.console\icons\full\elcl16. An easy solution would be to replace participant_rem.svg with one of these versions of rem_co.svg.

    PNG:
    participant_rem

    SVG of participant_rem:
    participant_rem2

    SVG of rem_co:
    rem_co2

The issues with pinned_ovr, build_exec (including its duplicate), and participant_rem are fixed in: #102

@Michael5601 Michael5601 added the bug Something isn't working label Oct 20, 2024
Michael5601 added a commit to Michael5601/eclipse.platform.images that referenced this issue Oct 20, 2024
@IamLRBA
Copy link

IamLRBA commented Oct 24, 2024

Hello @Michael5601 , if this issue is still active, i would like to work on if please.
Thanks!

@Michael5601
Copy link
Contributor Author

Hello @Michael5601 , if this issue is still active, i would like to work on if please. Thanks!

Hey @IamLRBA I appreciate your help but I already posted a PR that fixes the issue in #102. The PR is not yet accepted.

@IamLRBA
Copy link

IamLRBA commented Oct 25, 2024

Alright @Michael5601, I'll be delighted to help on any other issue if ever you have one.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants