-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mosquitto 2.0.20 fails to build on Linux without threads #3183
Labels
Component: libmosquitto
Status: Completed
Nothing further to be done with this issue, it can be closed by the requestor or committer.
Milestone
Comments
github-actions
bot
added
the
Status: Available
No one has claimed responsibility for resolving this issue.
label
Dec 6, 2024
arnout
pushed a commit
to buildroot/buildroot
that referenced
this issue
Dec 7, 2024
…read builds Fixes: http://autobuild.buildroot.net/results/1998881e9ab9ff396e6fd47b0d7c1298ccb25266/ http://autobuild.buildroot.net/results/0cb8e2dcee51007ee09506fa143e52cefbde5335/ And many more. A change in mosquitto 2.0.20 to fix builds on NetBSD broke WITH_THREADING=no builds as it unconditionally calls pthread functions. The issue has been reported upstream for ~1 month, but so far no fix so revert the NetBSD change for now instead to fix the build. https://www.eclipse.org/lists/mosquitto-dev/msg03003.html eclipse-mosquitto/mosquitto#3183 Signed-off-by: Peter Korsgaard <[email protected]>
jacmet
changed the title
mosquitto 2.0.20 fails to build Linux without threads
mosquitto 2.0.20 fails to build on Linux without threads
Dec 7, 2024
arnout
pushed a commit
to buildroot/buildroot
that referenced
this issue
Dec 8, 2024
…read builds Fixes: http://autobuild.buildroot.net/results/1998881e9ab9ff396e6fd47b0d7c1298ccb25266/ http://autobuild.buildroot.net/results/0cb8e2dcee51007ee09506fa143e52cefbde5335/ And many more. A change in mosquitto 2.0.20 to fix builds on NetBSD broke WITH_THREADING=no builds as it unconditionally calls pthread functions. The issue has been reported upstream for ~1 month, but so far no fix so revert the NetBSD change for now instead to fix the build. https://www.eclipse.org/lists/mosquitto-dev/msg03003.html eclipse-mosquitto/mosquitto#3183 Signed-off-by: Peter Korsgaard <[email protected]> (cherry picked from commit 0f88615) Signed-off-by: Peter Korsgaard <[email protected]>
arnout
pushed a commit
to buildroot/buildroot
that referenced
this issue
Dec 8, 2024
…read builds Fixes: http://autobuild.buildroot.net/results/1998881e9ab9ff396e6fd47b0d7c1298ccb25266/ http://autobuild.buildroot.net/results/0cb8e2dcee51007ee09506fa143e52cefbde5335/ And many more. A change in mosquitto 2.0.20 to fix builds on NetBSD broke WITH_THREADING=no builds as it unconditionally calls pthread functions. The issue has been reported upstream for ~1 month, but so far no fix so revert the NetBSD change for now instead to fix the build. https://www.eclipse.org/lists/mosquitto-dev/msg03003.html eclipse-mosquitto/mosquitto#3183 Signed-off-by: Peter Korsgaard <[email protected]> (cherry picked from commit 0f88615) Signed-off-by: Peter Korsgaard <[email protected]>
j1nx
pushed a commit
to OpenVoiceOS/buildroot
that referenced
this issue
Dec 16, 2024
…read builds Fixes: http://autobuild.buildroot.net/results/1998881e9ab9ff396e6fd47b0d7c1298ccb25266/ http://autobuild.buildroot.net/results/0cb8e2dcee51007ee09506fa143e52cefbde5335/ And many more. A change in mosquitto 2.0.20 to fix builds on NetBSD broke WITH_THREADING=no builds as it unconditionally calls pthread functions. The issue has been reported upstream for ~1 month, but so far no fix so revert the NetBSD change for now instead to fix the build. https://www.eclipse.org/lists/mosquitto-dev/msg03003.html eclipse-mosquitto/mosquitto#3183 Signed-off-by: Peter Korsgaard <[email protected]>
For mosquitto, threads are now standard. They are simply used in many places without verification: #3193 |
This is fixed in the fixes branch and will be part of 2.0.21. |
ralight
added
Component: libmosquitto
Status: Completed
Nothing further to be done with this issue, it can be closed by the requestor or committer.
and removed
Status: Available
No one has claimed responsibility for resolving this issue.
labels
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: libmosquitto
Status: Completed
Nothing further to be done with this issue, it can be closed by the requestor or committer.
As reported on the mailing list (https://www.eclipse.org/lists/mosquitto-dev/msg03003.html), the changes in 88b7bb3 unfortunately broke the builds on Linux on setups without threads, E.G.:
I see you replaced most, but not all pthread_* calls by COMPAT_pthread_*? Was this done on purpose or just a mistake?
The text was updated successfully, but these errors were encountered: