Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temperature Control: Swipe Gesture not working in Landscape Mode #57

Open
wba2hi opened this issue Feb 12, 2024 · 0 comments
Open

Temperature Control: Swipe Gesture not working in Landscape Mode #57

wba2hi opened this issue Feb 12, 2024 · 0 comments
Labels
bug Something isn't working low priority This issue has a low priority

Comments

@wba2hi
Copy link
Contributor

wba2hi commented Feb 12, 2024

Describe the bug
In Landscape Mode the Temperature can not be increased (swipe to the right) before decreasing the temperature (swipe to the left) because the SideSheet and it's draggable behavior always wins over both elements.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Temperature Control
  2. Rotate your device to landscape m ode
  3. Increase Temperature with Swipe Gesture -> Touch the point and swipe to the right to increase the temperature
  4. Swipe to the right starts to collapse the SideSheet

Expected behavior
4. SideSheet does not start to collapse and the Temperature is correctly increased

Screenshots
n/a

Smartphone (please complete the following information):

  • Device: Google Pixel 3
  • OS: Android 12, API 31

Additional context

  • Temperature can be increased by clicking on desired temperature instead of swiping
  • Temperature can be increased by swiping the slider to the left side first, before swiping right

Potential solutions could be:

  • Disable SideSheet being draggable -> however that might be inconsistent to the BottomSheet
  • Change Slider to something else (e.g. instead of sliding use a + and - button to increase and decrease the temperature)
  • ... other solutions

Just suggestions, not mandatory to chose one :)

@Chrylo Chrylo added bug Something isn't working low priority This issue has a low priority labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low priority This issue has a low priority
Projects
None yet
Development

No branches or pull requests

2 participants