Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DependencyResourcesIT is failing on windows #3476

Open
1 task
rohanKanojia opened this issue Oct 20, 2024 · 0 comments · May be fixed by #3482
Open
1 task

DependencyResourcesIT is failing on windows #3476

rohanKanojia opened this issue Oct 20, 2024 · 0 comments · May be fixed by #3482
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@rohanKanojia
Copy link
Member

rohanKanojia commented Oct 20, 2024 •
edited
Loading

Component

Gradle ITests

Task description

Description

Related to #3406

⚠️ A windows machine is required to reproduce and fix problems in this issue

DependencyResourcesIT is failing on windows due to not being able to clean directory properly.

In order to fix it, I see these two options.

  • Move second test k8sResource_whenRunWithReplicas_generatesK8sManifestsIncludingDependencies to a separate test class, also make it use a different test project.
  • Change the build directory used in the tests so that they don't conflict with each other. Use jkube.targetDir property to override directory for jkube resource output. See fix failing unit tests in gradle-plugin/it module #3406 (comment)

Expected Behavior

DependencyResourcesIT should pass on windows

Acceptance Criteria

  • DependencyResourcesIT should pass on windows and Linux
@rohanKanojia rohanKanojia added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 20, 2024
@rohanKanojia rohanKanojia mentioned this issue Oct 20, 2024
Open
1 task
@rexrk rexrk linked a pull request Oct 22, 2024 that will close this issue
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes file locking issue in DependencyResourcesIT rexrk/jkube
1 participant
@rohanKanojia