Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASTParser.createBindings does not use the unitResolver field #3428

Open
robstryker opened this issue Dec 9, 2024 · 0 comments
Open

ASTParser.createBindings does not use the unitResolver field #3428

robstryker opened this issue Dec 9, 2024 · 0 comments

Comments

@robstryker
Copy link
Contributor

ASTParser.createBindings does not direct such requests to the current unitResolver, but rather uses the ECJ implementation with no opportunity to override it.

I have moved the method into ASTParser and added a parameter for the proper unit resolver to be used. Since this is a public package, I have left the old method where it was (in CompilationUnitResolver) and forwarded the request to the newer method.
robstryker pushed a commit to robstryker/eclipse.jdt.core that referenced this issue Dec 9, 2024
Fixes eclipse-jdt#3428 - Ensure calls to ASTParser.createBindings use…
2ff1a47 
… the correct unit resolver

Signed-off-by: Rob Stryker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robstryker