Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing code implementation in the compiler #3396

Open
laeubi opened this issue Dec 4, 2024 · 9 comments
Open

Missing code implementation in the compiler #3396

laeubi opened this issue Dec 4, 2024 · 9 comments
Assignees
Labels
bug Something isn't working needinfo Further information is requested

Comments

@laeubi
Copy link
Contributor

laeubi commented Dec 4, 2024

I moved some code from one plugin to the other (but still require the new bundle with re-export) and now I get javadoc errors in JDT:

Missing code implementation in the compiler

Eclipse SDK

Version: 2024-12 (4.34)
Build id: I20241120-1800

@jukzi
Copy link
Contributor

jukzi commented Dec 4, 2024

Minimal reproducer required. The Message is from org.eclipse.jdt.internal.compiler.problem.ProblemReporter.abortDueToInternalError(String, ASTNode) which is supposed to also give details about source location. Maybe that error handling needs to be improved for your case too.

@jukzi jukzi added bug Something isn't working needinfo Further information is requested labels Dec 4, 2024
@laeubi
Copy link
Contributor Author

laeubi commented Dec 4, 2024

which is supposed to also give details about source location. Maybe that error handling needs to be improved for your case too.

The message is all I get, no further details or error logs.

@laeubi
Copy link
Contributor Author

laeubi commented Dec 4, 2024

Minimal reproducer required.

I only can give the hint from the inital report, e.g. I have a javac reference in Bundle A

	/**
	 * See doc on {@link FileLocator#find(Bundle, IPath, Map)}
	 */

now I move the FileLocator to another required bundle then the error shows up.

@srikanth-sankaran
Copy link
Contributor

Jay, can you take a look ? Thanks!

@jarthana
Copy link
Member

jarthana commented Dec 4, 2024

Minimal reproducer required.

I only can give the hint from the inital report, e.g. I have a javac reference in Bundle A

You meant Javadoc reference, right?

@laeubi
Copy link
Contributor Author

laeubi commented Dec 4, 2024

Yes javadoc of course :-)

@jarthana
Copy link
Member

jarthana commented Dec 4, 2024

OK, I tried this within JDT. That is, moved some stuff from jdt.core (referenced via Javadoc in the same bundle) to compiler.batch, which is a required bundle for the former. Don't see the problem. There has to be something special about reported case.

@stephan-herrmann
Copy link
Contributor

Minimal reproducer required. The Message is from org.eclipse.jdt.internal.compiler.problem.ProblemReporter.abortDueToInternalError(String, ASTNode) which is supposed to also give details about source location. Maybe that error handling needs to be improved for your case too.

More specifically: org.eclipse.jdt.internal.compiler.problem.ProblemReporter.needImplementation(ASTNode).

@jarthana when comparing invalidMethod() with javadocInvalidMethod() I could imagine we're hitting a case of ProblemReasons.NotAccessible which would be handled in the former method, but is not in the latter. I see some more problem reasons handled only in invalidMethod() but those look less relevant for javadoc, but ideally both methods would handle the same set of reasons?

@jarthana
Copy link
Member

jarthana commented Dec 5, 2024

@stephan-herrmann Thanks, sounds plausible. But I am having a hard time coming up with a testcase, though. Any chance you already have one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needinfo Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants