Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Regression on Eclipse 4.31 launcher using relative ../bin/java of a JDK with macOS layout #631

Closed
mdaloia opened this issue May 14, 2024 · 6 comments
Labels

Comments

@mdaloia
Copy link
Contributor

mdaloia commented May 14, 2024

It seems that this change 19582c5 introduced with PR #481 on the native macOS launcher of Eclipse 4.31 breaks a previously working scenario (until 4.30) where the JVM used to launch Eclipse has a macOS layout (as it has Temurin) and you reference it under -vm in eclipse.ini with a relative path to bin/java

Error:

The JVM shared library "/Users/mdaloia/Downloads/launcher-bug/Eclipse.app/Contents/MacOS//../../../jdk-17.0.11+9-jre/Contents/Home/bin/../lib/server/libjvm.dylib"
does not contain the JNI_CreateJavaVM symbol.

image

Steps to reproduce

  1. Download Eclipse 4.31

  2. Open it once (to check that it work with the embedded JustJ JRE and so the macOS does the Notarization Gatekeeper check, otherwise if you modify it directly it will say that it is damaged).

  3. Download Adoptium Temurin JRE 17 for macOS (https://adoptium.net/temurin/releases/ )

  4. Extract the JRE at the same level of the Eclipse.app
    image

  5. Modify the -vm arg of Eclipse.app/Contents/Eclipse/eclipse.ini to:

    -vm
    ../../../jdk-17.0.11+9-jre/Contents/Home/bin/java
    
  6. Execute Eclipse.app

Workaround

Use:

 -vm
 ../../../jdk-17.0.11+9-jre/Contents/Home/lib/libjli.dylib
@mdaloia
Copy link
Contributor Author

mdaloia commented May 14, 2024

By the way, if you use the absolute path pointing to the same bin/java executable it works ok.

@HannesWell
Copy link
Member

By the way, if you use the absolute path pointing to the same bin/java executable it works ok.

Do you think you can provide a PR with a proposed solution?
But since I cannot help at all with Mac, maybe @sravanlakkimsetti or @Phillipus can help?

@mdaloia
Copy link
Contributor Author

mdaloia commented May 14, 2024

I'm sorry, but I don't know about ObjectiveC coding nor I have the proper environment.... maybe the original author could help on this...

@subyssurendran666 could you take a look at it?

Thanks in advance

@subyssurendran666
Copy link
Contributor

@mdaloia Sure, I'll check this issue and get back to you.

@mdaloia
Copy link
Contributor Author

mdaloia commented Jun 13, 2024

@subyssurendran666 Did you have time to look at it?

Copy link

This issue has been inactive for 180 days and is therefore labeled as stale.
If this issue became irrelevant in the meantime please close it as completed. If it is still relevant and you think it should be fixed some possibilities are listed below.
Please read https://github.com/eclipse-equinox/.github/blob/main/CONTRIBUTING.md#contributing-to-eclipse-equinox for ways to influence development.

@github-actions github-actions bot added the stale label Dec 11, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants