Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branding : ECL use Core website design ... Others designs are asked by users #16

Open
julien- opened this issue Nov 4, 2019 · 6 comments · May be fixed by #24
Open

Branding : ECL use Core website design ... Others designs are asked by users #16

julien- opened this issue Nov 4, 2019 · 6 comments · May be fixed by #24
Assignees

Comments

@julien-
Copy link
Collaborator

julien- commented Nov 4, 2019

ECL components use Core websites design : Site Header Page Header Footer

@julien- julien- self-assigned this Nov 4, 2019
@steeff
Copy link
Contributor

steeff commented Nov 14, 2019

Hi Julien,
yes please especially the one that displays the site name in the header instead of the current implementation of the page title. @papegaill is going to provide a patch on the 2.0 version

@papegaill
Copy link
Contributor

papegaill commented Nov 14, 2019

Hi @steeff and @julien- ,
Here is the created patch to replace the page-title by the site-name for latest release v2.0.1:
header_footer_corporate_v2.0.1_replace_page-title_by_site-name.patch.zip

@julien-
Copy link
Collaborator Author

julien- commented Nov 14, 2019

@papegaill Thank you for your improvement. But there is no need to patch because it is a release so use projects[header_footer_corporate][download][tag] = "v2.0.1" in your site.make (if you are using Toolkit) or update manually your module.
And for my futur development I will start from/merge your changes.

PS : I am currently in other project so I will work on this issue during December

@steeff
Copy link
Contributor

steeff commented Nov 14, 2019

plz note that this patch has not been integrated into any version of the module because it changes the way the header is displayed.
Currently this is the page title that is output (since version 1.0.8) and with the patch this is the site name as it was the case util 1.0.8
so if you still need to display the page title in the header do not use that patch !!

@julien-
Copy link
Collaborator Author

julien- commented Nov 14, 2019

@steeff OK thank you for the precision

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants