Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CIs for Spearman' rho and Kendall's tau #141

Open
IndrajeetPatil opened this issue Mar 19, 2021 · 2 comments
Open

add CIs for Spearman' rho and Kendall's tau #141

IndrajeetPatil opened this issue Mar 19, 2021 · 2 comments
Assignees
Labels
enhancement 💥 Implemented features can be improved or revised

Comments

@IndrajeetPatil
Copy link
Member

We do this only for Pearson's. But correlation also returns CIs for these other measures that we can utilize for reporting.

@IndrajeetPatil IndrajeetPatil added the enhancement 💥 Implemented features can be improved or revised label Mar 19, 2021
@IndrajeetPatil IndrajeetPatil self-assigned this Mar 19, 2021
@IndrajeetPatil
Copy link
Member Author

This is not going to be straightforward unfortunately.

correlation works with raw data and computes correlations, while parameters works with correlation test related htest objects. We will have to implement something like cor_to_ci() in parameters itself so that the returned summary dataframes already contain confidence intervals.

@DominiqueMakowski
Copy link
Member

I think the most straightforward way is to implement report's support for correlation objects (easycorrelation class), and then people will just have to use correlation::cor_test() or correlation::correlation() with report if they want the comprehensive report 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 💥 Implemented features can be improved or revised
Projects
None yet
Development

No branches or pull requests

2 participants