Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data attribute in principal_component #350

Open
DominiqueMakowski opened this issue Nov 25, 2020 · 3 comments
Open

data attribute in principal_component #350

DominiqueMakowski opened this issue Nov 25, 2020 · 3 comments
Labels
Consistency 🍏 🍎 Expected output across functions could be more similar Low priority 😴 This issue does not impact package functionality much

Comments

@DominiqueMakowski
Copy link
Member

parameters/R/principal_components.R

Lines 199 to 200 in 85d8e85

attr(loadings, "data") <- data_name
attr(loadings, "data_set") <- original_data

That's minor but I just noticed that the data name and dataset as saved under these names, which is a bit counterintuitive (I would have expected data to be the dataset and for the name something like data_name or such). Do you have in mind if this is used in other places that in this context (to see whether it would be a problem to change it)?
Tam-Pham added a commit to Tam-Pham/parameters that referenced this issue Nov 25, 2020
@Tam-Pham
add NA row in predict output where original data is missing
6553738 
easystats#350 (need to update once this issue is resolved)
@Tam-Pham Tam-Pham mentioned this issue Nov 25, 2020
Closed
strengejacke added a commit that referenced this issue Nov 25, 2020
@strengejacke
#350
83fd175
@strengejacke
Copy link
Member

Do you have in mind if this is used in other places that in this context (to see whether it would be a problem to change it)?

Not sure, let's try :-) I think in performance we access the attribute, but not in see. Thus we probably don't access the data attribute for PCA anywhere right now?

strengejacke added a commit that referenced this issue Nov 25, 2020
@strengejacke
revert #350
abc447c
@strengejacke
Copy link
Member

Ok, maybe we need a more smooth transition I just saw ... ^^

@strengejacke strengejacke added the Consistency 🍏 🍎 Expected output across functions could be more similar label Nov 25, 2020
@DominiqueMakowski
Copy link
Member Author

we probably don't access the data attribute for PCA anywhere right now

You mean the data name or the dataset?

@strengejacke strengejacke added the Low priority 😴 This issue does not impact package functionality much label Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Consistency 🍏 🍎 Expected output across functions could be more similar Low priority 😴 This issue does not impact package functionality much
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DominiqueMakowski @strengejacke